src/arm64/macro-assembler-arm64.cc - Issue 330053002: ARM, ARM64: Optimize array copy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/macro-assembler-arm64.cc

Issue 330053002: ARM, ARM64: Optimize array copy (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm64/macro-assembler-arm64.cc

diff --git a/src/arm64/macro-assembler-arm64.cc b/src/arm64/macro-assembler-arm64.cc

index f2e49b4639cd175e8398a4798a83b327d06ffc4f..ef0fe9be284c5f6c7e7f27ff25941d3e65a02e6a 100644

--- a/src/arm64/macro-assembler-arm64.cc

+++ b/src/arm64/macro-assembler-arm64.cc

@@ -434,7 +434,10 @@ void MacroAssembler::AddSubMacro(const Register& rd,

(rn.IsZero() && !operand.IsShiftedRegister()) ||

(operand.IsShiftedRegister() && (operand.shift() == ROR))) {

UseScratchRegisterScope temps(this);

- Register temp = temps.AcquireSameSizeAs(rn);

+ // Use rd as a temp if possible.

+ Register temp =

+ (rd.Is(rn) || rd.IsSP() || rd.IsZero()) ?

+ temps.AcquireSameSizeAs(rn) : rd;

Mov(temp, operand);

AddSub(rd, rn, temp, S, op);

} else {

« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »