Issue 330043002: Simplified code for styleResolverChanged.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 330043002: Simplified code for styleResolverChanged. (Closed)

Created:
6 years, 6 months ago by rune

Modified:
6 years, 6 months ago

Reviewers:
esprehn, ojan

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Simplified code for styleResolverChanged. Removed StyleResolverChange class by: - Marking Document scope for recalc in the stylesheet collection class like we do for shadow scopes instead of propagating it up to Document. - Move the check for doing full repaint after all stylesheets have been loaded to Document::styleResolverChanged. Introduced a shouldUpdateDocumentStyleSheetCollection helper method. R=esprehn@chromium.org,ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176050

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -55 lines)			Patch
M	Source/core/dom/Document.cpp	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	Source/core/dom/DocumentStyleSheetCollection.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/DocumentStyleSheetCollection.cpp	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	Source/core/dom/ShadowTreeStyleSheetCollection.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/ShadowTreeStyleSheetCollection.cpp	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	Source/core/dom/StyleEngine.h	View	4 chunks	+4 lines, -20 lines	0 comments	Download
M	Source/core/dom/StyleEngine.cpp	View	5 chunks	+15 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/330043002/1

6 years, 6 months ago (2014-06-12 19:37:04 UTC) #3

Message was sent while issue was closed.

Change committed as 176050

Expand Messages | Collapse Messages