Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 330023004: resolve symbol collsion with zlib 1.2.8 (Closed)

Created:
6 years, 6 months ago by Bo Xu
Modified:
6 years, 6 months ago
Reviewers:
jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

resolve symbol collsion with zlib 1.2.8 R=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/fda75e4

Patch Set 1 #

Patch Set 2 : Add a missing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M core/include/thirdparties/zlib/zlib.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M core/src/fxcodec/fx_zlib/zlib_v128/zlib.h View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bo Xu
John, can you or Dean review this? Thanks!
6 years, 6 months ago (2014-06-12 17:55:03 UTC) #1
jam
lgtm
6 years, 6 months ago (2014-06-12 19:41:03 UTC) #2
Bo Xu
6 years, 6 months ago (2014-06-12 20:42:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as rfda75e4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698