Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1521)

Unified Diff: cc/layers/picture_layer_impl.cc

Issue 330003003: cc: Pass ideal contents scale to PictureLayerTiling UpdateTilePriorities. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated test Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/layers/picture_layer_impl_unittest.cc » ('j') | cc/layers/picture_layer_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/picture_layer_impl.cc
diff --git a/cc/layers/picture_layer_impl.cc b/cc/layers/picture_layer_impl.cc
index 5452941793305803df01e77e42039b1e5272a1f4..ec001a3606540552e6e7024312fef02d075c785e 100644
--- a/cc/layers/picture_layer_impl.cc
+++ b/cc/layers/picture_layer_impl.cc
@@ -425,8 +425,6 @@ void PictureLayerImpl::UpdateTiles() {
was_screen_space_transform_animating_ =
draw_properties().screen_space_transform_is_animating;
- // TODO(sohanjg): Avoid needlessly update priorities when syncing to a
- // non-updated tree which will then be updated immediately afterwards.
should_update_tile_priorities_ = true;
UpdateTilePriorities();
@@ -472,11 +470,9 @@ void PictureLayerImpl::UpdateTilePriorities() {
WhichTree tree =
layer_tree_impl()->IsActiveTree() ? ACTIVE_TREE : PENDING_TREE;
for (size_t i = 0; i < tilings_->num_tilings(); ++i) {
- // TODO(sohanjg): Passing MaximumContentsScale as layer contents scale
- // in UpdateTilePriorities is wrong and should be ideal contents scale.
tilings_->tiling_at(i)->UpdateTilePriorities(tree,
visible_layer_rect,
- MaximumTilingContentsScale(),
+ ideal_contents_scale_,
current_frame_time_in_seconds);
}
« no previous file with comments | « no previous file | cc/layers/picture_layer_impl_unittest.cc » ('j') | cc/layers/picture_layer_impl_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698