Files.app: Add browser tests to test the default action dialog.

Files.app: Add browser tests to test the default action dialog.

BUG=383738
TEST=run the test

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277392

[hirono, 2014-06-13 04:33:08]

PTAL the CL?
This CL depends on crrev.com/336473002.
Thank you!

[yoshiki, 2014-06-13 12:07:06]

sorry for late. lgtm

https://codereview.chromium.org/330003002/diff/60001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/file_manager_browsertest.cc (right):

https://codereview.chromium.org/330003002/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/file_manager_browsertest.cc:967:
DISABLED_ExecuteDefaultTaskOnDrive
nit: 4 space

https://codereview.chromium.org/330003002/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/file_manager_browsertest.cc:980:
DISABLED_DefaultActionDialog
ditto

https://codereview.chromium.org/330003002/diff/60001/chrome/test/data/extensi...
File
chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/tasks.js
(right):

https://codereview.chromium.org/330003002/diff/60001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/tasks.js:31:
new FakeTask(true, 'dummytaskid|open-with', 'The dummy task for test'),
nit: please add a period after sentence. (same below)

https://codereview.chromium.org/330003002/diff/60001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/tasks.js:144:
else
nit: please add braces for multiple-line else-block.

[hirono, 2014-06-16 03:51:09]

Thank you!

https://codereview.chromium.org/330003002/diff/60001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/file_manager_browsertest.cc (right):

https://codereview.chromium.org/330003002/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/file_manager_browsertest.cc:967:
DISABLED_ExecuteDefaultTaskOnDrive
On 2014/06/13 12:07:06, yoshiki wrote:
> nit: 4 space

This becomes 2 spaces after git cl format.

https://codereview.chromium.org/330003002/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/file_manager_browsertest.cc:980:
DISABLED_DefaultActionDialog
On 2014/06/13 12:07:06, yoshiki wrote:
> ditto

Done.

https://codereview.chromium.org/330003002/diff/60001/chrome/test/data/extensi...
File
chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/tasks.js
(right):

https://codereview.chromium.org/330003002/diff/60001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/tasks.js:31:
new FakeTask(true, 'dummytaskid|open-with', 'The dummy task for test'),
On 2014/06/13 12:07:06, yoshiki wrote:
> nit: please add a period after sentence. (same below)

Actually these are not sentences, just names of tasks.
I replaced the texts so that they look like task names.

https://codereview.chromium.org/330003002/diff/60001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/tasks.js:144:
else
On 2014/06/13 12:07:06, yoshiki wrote:
> nit: please add braces for multiple-line else-block.

Done.

[hirono, 2014-06-16 03:51:13]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-06-16 03:51:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hirono@chromium.org/330003002/80001

[commit-bot: I haz the power, 2014-06-16 10:06:12]

Change committed as 277392