Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 329993006: Implement main blink target in GN. (Closed)

Created:
6 years, 6 months ago by brettw
Modified:
6 years, 6 months ago
Reviewers:
jamesr
CC:
blink-reviews, apavlov+blink_chromium.org, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, jamesr, caseq+blink_chromium.org, arv+blink, malch+blink_chromium.org, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, Mads Ager (chromium), lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, kouhei+heap_chromium.org, Mikhail
Project:
blink
Visibility:
Public.

Description

Implement main blink target in GN. This adds the "blink" and "blink_minimal" targets which code in Chrome generally uses to depend on Blink. These just forward to already-existing subtargets. Adds visibility to other BUILD.gn files in blink to mark all non-public files visible only to either WebKit/* or WebKit/Source/* R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176546

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -16 lines) Patch
M Source/BUILD.gn View 2 chunks +2 lines, -8 lines 0 comments Download
M Source/bindings/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/core/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/modules/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/modules/v8/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/scripts/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/scripts/scripts.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/BUILD.gn View 8 chunks +7 lines, -6 lines 0 comments Download
M Source/core/inspector/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/platform/BUILD.gn View 1 2 3 5 chunks +6 lines, -1 line 0 comments Download
M Source/platform/heap/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/wtf/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M public/BUILD.gn View 1 3 chunks +34 lines, -1 line 0 comments Download
M public/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M public/blink.gyp View 3 chunks +4 lines, -0 lines 0 comments Download
M public/blink_devtools.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
Depends on https://codereview.chromium.org/343993002/ landing (otherwise visibility breaks)
6 years, 6 months ago (2014-06-19 17:52:33 UTC) #1
jamesr
https://codereview.chromium.org/329993006/diff/20001/Source/bindings/scripts/scripts.gni File Source/bindings/scripts/scripts.gni (right): https://codereview.chromium.org/329993006/diff/20001/Source/bindings/scripts/scripts.gni#newcode38 Source/bindings/scripts/scripts.gni:38: if (defined(invoker.visibility)) { should this just happen for all ...
6 years, 6 months ago (2014-06-19 18:01:14 UTC) #2
brettw
https://codereview.chromium.org/329993006/diff/20001/Source/bindings/scripts/scripts.gni File Source/bindings/scripts/scripts.gni (right): https://codereview.chromium.org/329993006/diff/20001/Source/bindings/scripts/scripts.gni#newcode38 Source/bindings/scripts/scripts.gni:38: if (defined(invoker.visibility)) { Currently, templates do nothing magic with ...
6 years, 6 months ago (2014-06-19 18:22:55 UTC) #3
jamesr
lgtm
6 years, 6 months ago (2014-06-19 18:27:46 UTC) #4
brettw
6 years, 6 months ago (2014-06-19 20:57:52 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 manually as r176546.

Powered by Google App Engine
This is Rietveld 408576698