Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 329993002: Only grant MidiSysExMessage if needed. (Closed)

Created:
6 years, 6 months ago by Miguel Garcia
Modified:
6 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, wjia+watch_chromium.org, mcasas+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Only grant MidiSysExMessage if needed. It seems that right now we are granting it to child policy process even if the permission was not granted. Rename the success parameter to is_allowed. To match what the renderer expects. TBR=tsepez,dalecurtis BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276720

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M content/browser/renderer_host/media/midi_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/midi_dispatcher_host.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M content/common/media/midi_messages.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Miguel Garcia
Takashi, I am working on granting permissions for a different API (push messages) and was ...
6 years, 6 months ago (2014-06-12 09:32:00 UTC) #1
Takashi Toyoshima
Thank you for catching this issue. Yes, this should be fixed as you changed. LGTM.
6 years, 6 months ago (2014-06-12 10:01:57 UTC) #2
Takashi Toyoshima
+tsepez@ for ipc +dalecurtis@ for media
6 years, 6 months ago (2014-06-12 10:04:12 UTC) #3
Miguel Garcia
The CQ bit was checked by miguelg@chromium.org
6 years, 6 months ago (2014-06-12 10:48:14 UTC) #4
Miguel Garcia
On 2014/06/12 10:04:12, Takashi Toyoshima (chromium) wrote: > +tsepez@ for ipc > +dalecurtis@ for media ...
6 years, 6 months ago (2014-06-12 10:48:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/329993002/1
6 years, 6 months ago (2014-06-12 10:50:00 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 17:11:44 UTC) #7
Message was sent while issue was closed.
Change committed as 276720

Powered by Google App Engine
This is Rietveld 408576698