Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 329943003: Fix resolving protocol-agnostic <svg:image> URLs in about:blank iframes (Closed)

Created:
6 years, 6 months ago by fs
Modified:
6 years, 6 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, rwlbuis
Project:
blink
Visibility:
Public.

Description

Fix resolving protocol-agnostic <svg:image> URLs in about:blank iframes When resolving a protocol-agnostic URL against a base of 'about:blank', the result would be an invalid (and empty) URL, because of missing special- casing of 'about:blank' - which is present in Document::completeURLWithOverride. Fix by modifying SVGImageLoader::sourceURI to always resolve the URL using Document::completeURLWithOverride to not miss out on this special-casing logic for 'about:blank' base URLs. BUG=379100 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -3 lines) Patch
A LayoutTests/http/tests/svg/image-base-within-aboutblank-iframe.html View 1 chunk +29 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/svg/image-base-within-aboutblank-iframe-expected.html View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/svg/SVGImageLoader.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
fs
(Couldn't quite shake the "crazy!" feeling here, but...)
6 years, 6 months ago (2014-06-12 16:18:01 UTC) #1
pdr.
On 2014/06/12 16:18:01, fs wrote: > (Couldn't quite shake the "crazy!" feeling here, but...) LGTM
6 years, 6 months ago (2014-06-12 16:24:28 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 6 months ago (2014-06-12 16:24:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/329943003/1
6 years, 6 months ago (2014-06-12 16:25:37 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-12 17:33:27 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 18:39:21 UTC) #6
Message was sent while issue was closed.
Change committed as 176043

Powered by Google App Engine
This is Rietveld 408576698