Issue 329933003: Refactor the Connection and Generator so the Creator is completely

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 329933003: Refactor the Connection and Generator so the Creator is completely (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)

Modified:
6 years, 6 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Refactor the Connection and Generator so the Creator is completely encapsulated by the Generator. Merge internal change: 69000832 R=rch@chromium.org

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+234 lines, -111 lines)			Patch
M	net/net.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/quic/quic_connection.h	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	net/quic/quic_connection.cc	View	12 chunks	+22 lines, -15 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	net/quic/quic_framer.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/quic/quic_packet_creator.h	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	net/quic/quic_packet_creator.cc	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	net/quic/quic_packet_creator_test.cc	View	4 chunks	+4 lines, -2 lines	0 comments	Download
M	net/quic/quic_packet_generator.h	View	3 chunks	+41 lines, -4 lines	0 comments	Download
M	net/quic/quic_packet_generator.cc	View	12 chunks	+65 lines, -26 lines	0 comments	Download
M	net/quic/quic_packet_generator_test.cc	View	22 chunks	+37 lines, -35 lines	0 comments	Download
M	net/quic/test_tools/quic_connection_peer.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	net/quic/test_tools/quic_packet_creator_peer.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/quic/test_tools/quic_packet_creator_peer.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
A	net/quic/test_tools/quic_packet_generator_peer.h	View	1 chunk	+29 lines, -0 lines	0 comments	Download
A	net/quic/test_tools/quic_packet_generator_peer.cc	View	1 chunk	+20 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm