Issue 329933002: rebaseline_server: change 2 image expectations within unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 329933002: rebaseline_server: change 2 image expectations within unittests (Closed)

Created:
6 years, 6 months ago by epoger

Modified:
6 years, 6 months ago

Reviewers:
rmistry

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

rebaseline_server: change 2 image expectations within unittests NOTRY=True TBR=rmistry Committed: https://skia.googlesource.com/skia/+/cbbc7bf971fdaaae6dbb09fef6c611f3fb806a14

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -21 lines)			Patch
M	gm/rebaseline_server/testdata/inputs/gm-actuals/Test-Android-GalaxyNexus-SGX540-Arm7-Release/actual-results.json	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	gm/rebaseline_server/testdata/inputs/gm-expectations/Test-Android-GalaxyNexus-SGX540-Arm7-Release/expected-results.json	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	gm/rebaseline_server/testdata/outputs/expected/compare_to_expectations_test.CompareToExpectationsTest.test_gm/gm.json	View	4 chunks	+17 lines, -17 lines	0 comments	Download

Total messages: 6 (0 generated)

epoger

There are 4 image pairs in the compare_to_expectations unittest that have mismatching image sizes. Changing ...

6 years, 6 months ago (2014-06-12 03:01:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/329933002/1

6 years, 6 months ago (2014-06-12 03:02:22 UTC) #4

commit-bot: I haz the power

Change committed as cbbc7bf971fdaaae6dbb09fef6c611f3fb806a14

6 years, 6 months ago (2014-06-12 03:02:31 UTC) #5

Message was sent while issue was closed.

LGTM