Issue 3299002: [glibc] Allow building on case insensitive filesystems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3299002: [glibc] Allow building on case insensitive filesystems (Closed)

Created:
10 years, 3 months ago by Mark Seaborn

Modified:
9 years, 5 months ago

Reviewers:
khim, khimg, pasko-google - do not use

CC:
native-client-reviews_googlegroups.com

Base URL:
ssh://gitrw.chromium.org/nacl-glibc

Visibility:
Public.

Description

Allow building on case insensitive filesystems Use the suffix ".ons" instead of ".oS", because the latter clashes with ".os". ".oS" was used for object files to be included in libc_nonshared.a. ".ons" is intended to suggest "nonshared". This allows building on Mac OS X, which uses a case insensitive filesystem by default. BUG=http://code.google.com/p/nativeclient/issues/detail?id=855 TEST="python build.py -b" on OS X with gawk and gsed installed from Mac Ports

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -20 lines)			Patch
M	Makeconfig	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	Makerules	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	extra-lib.mk	View	5 chunks	+7 lines, -7 lines	0 comments	Download
M	nptl/Makefile	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	scripts/check-local-headers.sh	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sysdeps/sparc/sparc32/sparcv9/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

You can suggest an alternative to ".ons" if you want. I wanted to stick with ...

10 years, 3 months ago (2010-09-01 19:15:22 UTC) #1

khimg

LGTM I'm not 100% sure I like this change, but if it's the only thing ...

10 years, 3 months ago (2010-09-01 19:27:44 UTC) #2

pasko-google - do not use

10 years, 3 months ago (2010-09-02 09:43:46 UTC) #3

LGTM

though Victor's idea to build glibc only on linux and copy it to other systems
is a perfect match to avoid patches like that. How many would there be?

Expand Messages | Collapse Messages