Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Issue 329873005: Fix rebaseline-o-matic logging (Closed)

Created:
6 years, 6 months ago by ojan
Modified:
6 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews
Visibility:
Public.

Description

Fix rebaseline-o-matic logging readline blocks, so reading stdout, then stderr doesn't make any sense because we'll block on each on. So if we print only to one of them, we'll just wait until the process completes. Also, simplify the readline loop in RebaselineOMatic to just use readline instead of poll. That way it avoids missing any output between the last poll and when the process finishes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176146

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : merge to ToT #

Patch Set 4 : fix git cl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 1 2 3 2 chunks +9 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ojan
This is kind of hard to test. :(
6 years, 6 months ago (2014-06-14 00:28:26 UTC) #1
Dirk Pranke
lgtm
6 years, 6 months ago (2014-06-14 00:32:38 UTC) #2
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 6 months ago (2014-06-14 00:33:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/329873005/60001
6 years, 6 months ago (2014-06-14 00:33:33 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-14 01:36:54 UTC) #5
Message was sent while issue was closed.
Change committed as 176146

Powered by Google App Engine
This is Rietveld 408576698