Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 329873002: Expose showModalDialog runtime flag via WebRuntimeFeatures (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Visibility:
Public.

Description

Expose showModalDialog runtime flag via WebRuntimeFeatures BUG=none R=ojan@chromium.org,atwilson@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-11 22:41:49 UTC) #1
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-11 23:35:18 UTC) #2
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 6 months ago (2014-06-11 23:37:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/329873002/1
6 years, 6 months ago (2014-06-11 23:38:35 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-11 23:45:14 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 00:07:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11643)
6 years, 6 months ago (2014-06-12 00:07:09 UTC) #7
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 6 months ago (2014-06-12 14:01:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/329873002/1
6 years, 6 months ago (2014-06-12 14:01:55 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-12 14:51:18 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 14:51:40 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/16552)
6 years, 6 months ago (2014-06-12 14:51:42 UTC) #12
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 6 months ago (2014-06-12 16:51:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/329873002/1
6 years, 6 months ago (2014-06-12 16:52:45 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 16:53:14 UTC) #15
Message was sent while issue was closed. 
Change committed as 176037

Powered by Google App Engine
This is Rietveld 408576698