Delete scrollingCoordinatorEnabled setting

Delete scrollingCoordinatorEnabled setting

The scrollingCoordinatorEnabled setting is redundant with acceleratedCompositingEnabled.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175999

[jamesr, 2014-06-11 21:44:10]

lgtm

https://codereview.chromium.org/329863002/diff/1/Source/core/page/Page.cpp
File Source/core/page/Page.cpp (right):

https://codereview.chromium.org/329863002/diff/1/Source/core/page/Page.cpp#ne...
Source/core/page/Page.cpp:169: if (!m_scrollingCoordinator &&
m_settings->acceleratedCompositingEnabled())
isn't the bit after the && always true?

[abarth-chromium, 2014-06-11 21:49:56]

On 2014/06/11 at 21:44:10, jamesr wrote:
> lgtm
> 
> https://codereview.chromium.org/329863002/diff/1/Source/core/page/Page.cpp
> File Source/core/page/Page.cpp (right):
> 
>
https://codereview.chromium.org/329863002/diff/1/Source/core/page/Page.cpp#ne...
> Source/core/page/Page.cpp:169: if (!m_scrollingCoordinator &&
m_settings->acceleratedCompositingEnabled())
> isn't the bit after the && always true?

It's false in the InspectorOverlay and in SVGImage.

[abarth-chromium, 2014-06-11 21:50:19]

On 2014/06/11 at 21:49:56, abarth wrote:
> On 2014/06/11 at 21:44:10, jamesr wrote:
> > lgtm
> > 
> > https://codereview.chromium.org/329863002/diff/1/Source/core/page/Page.cpp
> > File Source/core/page/Page.cpp (right):
> > 
> >
https://codereview.chromium.org/329863002/diff/1/Source/core/page/Page.cpp#ne...
> > Source/core/page/Page.cpp:169: if (!m_scrollingCoordinator &&
m_settings->acceleratedCompositingEnabled())
> > isn't the bit after the && always true?
> 
> It's false in the InspectorOverlay and in SVGImage.

Grep for setAcceleratedCompositingEnabled(false)

[abarth-chromium, 2014-06-11 21:50:29]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:51:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abarth@chromium.org/329863002/1

[commit-bot: I haz the power, 2014-06-11 22:59:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11626)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15690)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18823)

[commit-bot: I haz the power, 2014-06-11 23:00:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 23:00:05]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15754)

[abarth-chromium, 2014-06-12 03:32:15]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-06-12 03:32:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/abarth@chromium.org/329863002/1

[commit-bot: I haz the power, 2014-06-12 06:29:28]

Change committed as 175999