Source/modules/serviceworkers/FetchEvent.cpp - Issue 329853012: [ServiceWorker] Make Request class better conformance with the spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/FetchEvent.cpp

Issue 329853012: [ServiceWorker] Make Request class better conformance with the spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase and fix test Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/serviceworker/resources/request-worker.js ('K') | « Source/modules/serviceworkers/FetchEvent.h ('k') | Source/modules/serviceworkers/FetchHeaderList.h » ('j') | Source/modules/serviceworkers/FetchManager.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/FetchEvent.cpp

diff --git a/Source/modules/serviceworkers/FetchEvent.cpp b/Source/modules/serviceworkers/FetchEvent.cpp

index 3a4897c7c02bb12a3d5c8b121d68cd557453d37d..d337f1f410c78098ef882f8f606bfc0552b675c8 100644

--- a/Source/modules/serviceworkers/FetchEvent.cpp

+++ b/Source/modules/serviceworkers/FetchEvent.cpp

@@ -21,9 +21,9 @@ PassRefPtrWillBeRawPtr<FetchEvent> FetchEvent::create(PassRefPtr<RespondWithObse

return adoptRefWillBeNoop(new FetchEvent(observer, request));

}

-Request* FetchEvent::request() const

+PassRefPtr<Request> FetchEvent::request() const

{

- return m_request.get();

+ return m_request;

}

bool FetchEvent::isReload() const