Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Side by Side Diff: Source/modules/serviceworkers/RequestInit.h

Issue 329853012: [ServiceWorker] Make Request class better conformance with the spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase and fix test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef RequestInit_h 5 #ifndef RequestInit_h
6 #define RequestInit_h 6 #define RequestInit_h
7 7
8 #include "bindings/core/v8/Dictionary.h" 8 #include "bindings/core/v8/Dictionary.h"
9 #include "modules/serviceworkers/HeaderMap.h" 9 #include "modules/serviceworkers/Headers.h"
10 #include "wtf/RefPtr.h" 10 #include "wtf/RefPtr.h"
11 11
12 namespace WebCore { 12 namespace WebCore {
13 13
14 struct RequestInit { 14 struct RequestInit {
15 explicit RequestInit(const Dictionary& options) 15 explicit RequestInit(const Dictionary& options)
16 : method("GET")
17 { 16 {
18 options.get("url", url);
19 // FIXME: Spec uses ByteString for method. http://crbug.com/347426 17 // FIXME: Spec uses ByteString for method. http://crbug.com/347426
falken 2014/07/03 10:05:33 It looks like this FIXME is done?
horo 2014/07/03 12:40:30 Done.
20 options.get("method", method); 18 options.get("method", method);
21 options.get("headers", headers); 19 options.get("headers", headers);
20 if (!headers) {
21 options.get("headers", headersDictionary);
22 }
23 options.get("mode", mode);
24 options.get("credentials", credentials);
22 } 25 }
23 26
24 String url;
25 String method; 27 String method;
26 RefPtr<HeaderMap> headers; 28 RefPtr<Headers> headers;
29 Dictionary headersDictionary;
30 String mode;
31 String credentials;
27 }; 32 };
28 33
29 } 34 }
30 35
31 #endif // RequestInit_h 36 #endif // RequestInit_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698