Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chromeos/dbus/debug_daemon_client.cc

Issue 329853010: Additional methods for chrome.logPrivate API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/debug_daemon_client.cc
diff --git a/chromeos/dbus/debug_daemon_client.cc b/chromeos/dbus/debug_daemon_client.cc
index b73ccaa246f79d17dc3f4c6aad6fb8d38c647116..3cff583bbc8ee1258238f0c63437dd865270b1c7 100644
--- a/chromeos/dbus/debug_daemon_client.cc
+++ b/chromeos/dbus/debug_daemon_client.cc
@@ -46,8 +46,9 @@ class DebugDaemonClientImpl : public DebugDaemonClient {
virtual ~DebugDaemonClientImpl() {}
// DebugDaemonClient override.
- virtual void GetDebugLogs(base::File file,
- const GetDebugLogsCallback& callback) OVERRIDE {
+ virtual void DumpDebugLogs(bool is_compressed,
+ base::File file,
+ const GetDebugLogsCallback& callback) OVERRIDE {
dbus::FileDescriptor* file_descriptor = new dbus::FileDescriptor;
file_descriptor->PutValue(file.TakePlatformFile());
@@ -59,6 +60,7 @@ class DebugDaemonClientImpl : public DebugDaemonClient {
base::Unretained(file_descriptor)),
base::Bind(&DebugDaemonClientImpl::OnCheckValidityGetDebugLogs,
weak_ptr_factory_.GetWeakPtr(),
+ is_compressed,
base::Owned(file_descriptor),
callback),
false);
@@ -313,13 +315,15 @@ class DebugDaemonClientImpl : public DebugDaemonClient {
private:
// Called when a CheckValidity response is received.
- void OnCheckValidityGetDebugLogs(dbus::FileDescriptor* file_descriptor,
+ void OnCheckValidityGetDebugLogs(bool is_compressed,
+ dbus::FileDescriptor* file_descriptor,
const GetDebugLogsCallback& callback) {
// Issue the dbus request to get debug logs.
dbus::MethodCall method_call(
debugd::kDebugdInterface,
- debugd::kGetDebugLogs);
+ debugd::kDumpDebugLogs);
dbus::MessageWriter writer(&method_call);
+ writer.AppendBool(is_compressed);
writer.AppendFileDescriptor(*file_descriptor);
debugdaemon_proxy_->CallMethod(

Powered by Google App Engine
This is Rietveld 408576698