Additional methods for chrome.logPrivate API

chrome/common/extensions/api/log_private.idl

Index: chrome/common/extensions/api/log_private.idl
diff --git a/chrome/common/extensions/api/log_private.idl b/chrome/common/extensions/api/log_private.idl
index 454d18fbcda06c2c85442e49e1ae539e4e4ef81f..e0bd4bc9bdd10f9d6597344599c78048e24aca48 100644
--- a/chrome/common/extensions/api/log_private.idl
+++ b/chrome/common/extensions/api/log_private.idl
@@ -46,14 +46,34 @@ namespace logPrivate {
 
   callback GetHistoricalCallback = void (Result res);
 
+  callback DumpLogsCallback = void ([instanceOf=FileEntry] object logs);
+
+  callback CompletionCallback = void ();
+
+  // The type of the events to be recorded.
+  enum EventType { network };
+
+  // The type of the event sink where captured events will be sent.
+  enum EventSink {
+    // Events will be sent to the webapp via onCapturedEvents. 
+    capture,
+    // Events will be sent to a log file.

[not at google - send to devlin, 2014/07/18 22:45:09]

mention that they are written when dumpLogs is called.

[zel, 2014/07/22 01:26:35]

Done.

[zel, 2014/07/22 01:26:35]

Done.

+    file
+  };
+
   interface Functions {
     // Get the existing logs from ChromeOS system.
     static void getHistorical(Filter filter, GetHistoricalCallback callback);
-    static void startNetInternalsWatch();
-    static void stopNetInternalsWatch();
+    // Start capturing events of specific type.
+    static void startEventRecorder(EventType eventType, EventSink sink, CompletionCallback callback);
+    // Stop  capturing events of specific type.
+    static void stopEventRecorder(EventType eventType, CompletionCallback callback);

[not at google - send to devlin, 2014/07/18 22:45:09]

keep these to < 80 chars.

[zel, 2014/07/22 01:26:35]

Done.

+    // Dump all system and captured events into a .tar.gz file.
+    static void dumpLogs(DumpLogsCallback callback);

[not at google - send to devlin, 2014/07/18 22:45:09]

mention the structure of the tar

[zel, 2014/07/22 01:26:35]

Done.

   };
 
   interface Events {
-    static void onAddNetInternalsEntries(object[] entries);
+    // Receives events of type which is currently being captured.
+    static void onCapturedEvents(object[] entries);
   };
 };