Issue 329853006: Move RenderTextInfo and WordMeasurement into their own headers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 329853006: Move RenderTextInfo and WordMeasurement into their own headers. (Closed)

Created:
6 years, 6 months ago by jbroman

Modified:
6 years, 6 months ago

Reviewers:
leviw_travelin_and_unemployed, eae

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Move RenderTextInfo and WordMeasurement into their own headers. They don't really belong in their current headers, and it's confusing. For example, RenderInfo is defined in LineBreaker.h and its constructor and destructor are defined in RenderBlockLineLayout.cpp. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176057

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -66 lines)			Patch
M	Source/core/rendering/RenderBlockLineLayout.cpp	View	2 chunks	+2 lines, -10 lines	0 comments	Download
M	Source/core/rendering/line/BreakingContextInlineHeaders.h	View	2 chunks	+2 lines, -17 lines	0 comments	Download
M	Source/core/rendering/line/LineBreaker.h	View	1 chunk	+1 line, -11 lines	0 comments	Download
A +	Source/core/rendering/line/RenderTextInfo.h	View	2 chunks	+18 lines, -13 lines	0 comments	Download
A +	Source/core/rendering/line/WordMeasurement.h	View	2 chunks	+23 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jbroman

I was a little confused by this. Seems a little nicer to put these in ...

6 years, 6 months ago (2014-06-12 21:33:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/329853006/1

6 years, 6 months ago (2014-06-12 21:38:33 UTC) #4

Message was sent while issue was closed.

Change committed as 176057

Expand Messages | Collapse Messages