Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 329853005: IDL parser: align with current Web IDL specification (Closed)

Created:
6 years, 6 months ago by Jens Widell
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

IDL parser: align with current Web IDL specification Mostly renumbered and restructured grammar productions. Notable changes: - add support for static attributes via StaticMember - add support for built-in types ByteString and RegExp - allow trailing comma in enum declarations Depends on: IDL parser: drop AttributeOrOperation and StaticAttribute overrides https://codereview.chromium.org/336733002/ ...or else breaks Blink compile. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278365

Patch Set 1 #

Total comments: 14

Patch Set 2 : update spec links; cleanup #

Patch Set 3 : remove commented out "iterator" keyword #

Patch Set 4 : fix another spec link #

Total comments: 7

Patch Set 5 : extend commentary #

Total comments: 1

Patch Set 6 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -130 lines) Patch
M tools/idl_parser/idl_lexer.py View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M tools/idl_parser/idl_node.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/idl_parser/idl_parser.py View 1 2 3 4 5 29 chunks +138 lines, -109 lines 0 comments Download
M tools/idl_parser/idl_ppapi_lexer.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/idl_parser/idl_ppapi_parser.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/idl_parser/test_lexer/keywords.in View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/idl_parser/test_parser/enum_web.idl View 2 chunks +12 lines, -8 lines 0 comments Download
M tools/idl_parser/test_parser/interface_web.idl View 2 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Jens Widell
PTAL when convenient. Note that this is an RFC as much as anything else. This ...
6 years, 6 months ago (2014-06-12 13:29:16 UTC) #1
Jens Widell
https://codereview.chromium.org/329853005/diff/1/tools/idl_parser/idl_parser.py File tools/idl_parser/idl_parser.py (right): https://codereview.chromium.org/329853005/diff/1/tools/idl_parser/idl_parser.py#newcode196 tools/idl_parser/idl_parser.py:196: # [2] Add INLINE definition I don't know what ...
6 years, 6 months ago (2014-06-12 13:34:37 UTC) #2
noelallen1
Started to review, but not sure which IDL spec you are using since the production ...
6 years, 6 months ago (2014-06-12 19:33:37 UTC) #3
Jens Widell
On 2014/06/12 19:33:37, noelallen1 wrote: > Started to review, but not sure which IDL spec ...
6 years, 6 months ago (2014-06-12 20:10:00 UTC) #4
noelallen1
The commented out productions are open question still, maybe Nils wants to comment? But I ...
6 years, 6 months ago (2014-06-12 20:39:31 UTC) #5
Jens Widell
Updated patch to change spec links to point to http://heycam.github.io/webidl/, and removed the commented out ...
6 years, 6 months ago (2014-06-13 06:19:12 UTC) #6
noelallen1
slgtm
6 years, 6 months ago (2014-06-13 18:40:53 UTC) #7
Nils Barth (inactive)
LGTM with comment nits -- ok to commit once Blink parser transition CL lands. Thanks ...
6 years, 6 months ago (2014-06-16 06:50:48 UTC) #8
Nils Barth (inactive)
On 2014/06/12 20:39:31, noelallen1 wrote: > The commented out productions are open question still, maybe ...
6 years, 6 months ago (2014-06-16 06:51:48 UTC) #9
Jens Widell
https://codereview.chromium.org/329853005/diff/60001/tools/idl_parser/idl_parser.py File tools/idl_parser/idl_parser.py (right): https://codereview.chromium.org/329853005/diff/60001/tools/idl_parser/idl_parser.py#newcode529 tools/idl_parser/idl_parser.py:529: # [51-53] NOT IMPLEMENTED On 2014/06/16 06:50:48, Nils Barth ...
6 years, 6 months ago (2014-06-16 10:39:49 UTC) #10
Jens Widell
https://codereview.chromium.org/329853005/diff/1/tools/idl_parser/idl_parser.py File tools/idl_parser/idl_parser.py (right): https://codereview.chromium.org/329853005/diff/1/tools/idl_parser/idl_parser.py#newcode772 tools/idl_parser/idl_parser.py:772: # [77] Moved BYTESTRING, DOMSTRING, OBJECT, DATE, REGEXP to ...
6 years, 6 months ago (2014-06-16 10:53:11 UTC) #11
Nils Barth (inactive)
https://codereview.chromium.org/329853005/diff/1/tools/idl_parser/idl_parser.py File tools/idl_parser/idl_parser.py (right): https://codereview.chromium.org/329853005/diff/1/tools/idl_parser/idl_parser.py#newcode772 tools/idl_parser/idl_parser.py:772: # [77] Moved BYTESTRING, DOMSTRING, OBJECT, DATE, REGEXP to ...
6 years, 6 months ago (2014-06-17 05:08:18 UTC) #12
Nils Barth (inactive)
https://codereview.chromium.org/329853005/diff/80001/tools/idl_parser/idl_ppapi_lexer.py File tools/idl_parser/idl_ppapi_lexer.py (right): https://codereview.chromium.org/329853005/diff/80001/tools/idl_parser/idl_ppapi_lexer.py#newcode69 tools/idl_parser/idl_ppapi_lexer.py:69: lexer.Tokenize(open('test_parser/inline_ppapi.idl').read()) For bonus points, could you replace this resource-leaking ...
6 years, 6 months ago (2014-06-17 05:11:55 UTC) #13
Jens Widell
https://codereview.chromium.org/329853005/diff/1/tools/idl_parser/idl_parser.py File tools/idl_parser/idl_parser.py (right): https://codereview.chromium.org/329853005/diff/1/tools/idl_parser/idl_parser.py#newcode772 tools/idl_parser/idl_parser.py:772: # [77] Moved BYTESTRING, DOMSTRING, OBJECT, DATE, REGEXP to ...
6 years, 6 months ago (2014-06-17 06:18:37 UTC) #14
Nils Barth (inactive)
https://codereview.chromium.org/329853005/diff/1/tools/idl_parser/idl_parser.py File tools/idl_parser/idl_parser.py (right): https://codereview.chromium.org/329853005/diff/1/tools/idl_parser/idl_parser.py#newcode772 tools/idl_parser/idl_parser.py:772: # [77] Moved BYTESTRING, DOMSTRING, OBJECT, DATE, REGEXP to ...
6 years, 6 months ago (2014-06-17 06:28:25 UTC) #15
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 6 months ago (2014-06-19 11:40:06 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/329853005/100001
6 years, 6 months ago (2014-06-19 11:43:29 UTC) #17
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 14:43:28 UTC) #18
Message was sent while issue was closed.
Change committed as 278365

Powered by Google App Engine
This is Rietveld 408576698