Source/modules/notifications/Notification.h - Issue 329853004: Remove RefCountedGarbageCollected from EventTarget objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/Notification.h

Issue 329853004: Remove RefCountedGarbageCollected from EventTarget objects (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/encryptedmedia/MediaKeySession.h ('K') | « Source/modules/indexeddb/IDBTransaction.cpp ('k') | Source/modules/notifications/Notification.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/notifications/Notification.h

diff --git a/Source/modules/notifications/Notification.h b/Source/modules/notifications/Notification.h

index 50b7e9c747f4384b7f59dc65a27f8a65f9e5793f..0e8896377b4ba9ba4099d2db6218223760cd7d30 100644

--- a/Source/modules/notifications/Notification.h

+++ b/Source/modules/notifications/Notification.h

@@ -48,8 +48,7 @@ class Dictionary;

class ExecutionContext;

class NotificationPermissionCallback;

-class Notification : public RefCountedGarbageCollected<Notification>, public ScriptWrappable, public ActiveDOMObject, public EventTargetWithInlineData {

- DEFINE_EVENT_TARGET_REFCOUNTING(RefCountedGarbageCollected<Notification>);

+class Notification : public GarbageCollectedFinalized<Notification>, public ScriptWrappable, public ActiveDOMObject, public EventTargetWithInlineData {

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(Notification);

public:

static Notification* create(ExecutionContext*, const String& title, const Dictionary& options);