Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 329853002: Enable about:nacl and correct symbol visibility for the plugin (Closed)

Created:
6 years, 6 months ago by sehr
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Enable about:nacl and correct symbol visibility for the plugin After this change, if libppGoogleNaClPluginChrome.so is placed in the install directory it correctly starts and attempts to create a subprocess. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032 R=bradnelson@google.com, darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276724

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sehr
One more small step. I need to get packaging and process creation working.
6 years, 6 months ago (2014-06-11 21:29:22 UTC) #1
bradn
lgtm
6 years, 6 months ago (2014-06-11 21:42:02 UTC) #2
darin (slow to review)
LGTM
6 years, 6 months ago (2014-06-11 21:49:51 UTC) #3
sehr
The CQ bit was checked by sehr@chromium.org
6 years, 6 months ago (2014-06-11 23:37:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sehr@chromium.org/329853002/1
6 years, 6 months ago (2014-06-11 23:38:45 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 01:07:01 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 02:17:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_dbg/builds/28138) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19935)
6 years, 6 months ago (2014-06-12 02:17:11 UTC) #8
sehr
6 years, 6 months ago (2014-06-12 17:21:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r276724 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698