Correctly set up LayerTreeSettings for cc::Display.

Correctly set up LayerTreeSettings for cc::Display.

BUG=378549
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276769

[jamesr, 2014-06-11 21:15:53]

What was wrong with what we were doing before?  Does cc expect this object to
outlive the LayerTreeHost or something?

[jbauman, 2014-06-11 21:21:27]

On 2014/06/11 21:15:53, jamesr wrote:
> What was wrong with what we were doing before?  Does cc expect this object to
> outlive the LayerTreeHost or something?

The Renderer just takes a pointer to it, so it has to remain alive while the
Renderer remains alive. So putting it on the stack is a bad idea.

[jamesr, 2014-06-11 21:26:30]

Why doesn't it just copy it?  Settings is just a dumb (POD-ish) struct.

Anyway, this code lgtm

[jbauman, 2014-06-11 21:29:50]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:31:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbauman@chromium.org/329833002/1

[jamesr, 2014-06-11 21:31:48]

Wait, are you sure?  In LayerTreeHost I see:


  const LayerTreeSettings settings_;

so this line in the c'tors initializer list:

      settings_(settings),

will copy the settings.  The object doesn't have to live past the ::Create()
call

[jamesr, 2014-06-11 21:32:22]

Sorry I'm dumb - was looking at the wrong settings object.

[commit-bot: I haz the power, 2014-06-11 23:01:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15670)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18804)

[commit-bot: I haz the power, 2014-06-11 23:03:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 23:03:08]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15756)

[jbauman, 2014-06-12 16:01:31]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2014-06-12 16:03:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbauman@chromium.org/329833002/1

[commit-bot: I haz the power, 2014-06-12 18:55:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[commit-bot: I haz the power, 2014-06-12 19:30:33]

Change committed as 276769