Issue 329823002: scm.GIT.IsValidRevision: Only return True if the given object is a commit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 329823002: scm.GIT.IsValidRevision: Only return True if the given object is a commit (Closed)

Created:
6 years, 6 months ago by borenet

Modified:
6 years, 6 months ago

Reviewers:
iannucci, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

scm.GIT.IsValidRevision: Only return True if the given object is a commit BUG=383476 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=276487

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -3 lines)			Patch
	M	scm.py	View		1 chunk	+6 lines, -3 lines	0 comments	Download
	M	tests/scm_unittest.py	View		2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/329823002/1

6 years, 6 months ago (2014-06-11 20:34:54 UTC) #4

Ryan Tseng

A revert of this CL has been created in https://codereview.chromium.org/329393002/ by hinoka@google.com. The reason for ...

6 years, 6 months ago (2014-06-11 22:10:29 UTC) #6

ghost stip (do not use)

6 years, 6 months ago (2014-06-11 23:23:42 UTC) #7

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/334563002/ by stip@chromium.org.

The reason for reverting is: Other revert didn't stick..

Expand Messages | Collapse Messages