Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 329813003: Reland: Use labels to display views tab titles. (Closed)

Created:
6 years, 6 months ago by msw
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, please use gerrit instead
Visibility:
Public.

Description

Reland: Use labels to display views tab titles. The original r276450 was reverted in r276476 for leaks: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/3954 Fixed here by calling AddChildView(title_) on Tab (duh). Add a Label view to Tab for displaying the title. Remove Tab::PaintTitle, bounds and font members. Remove unnecessary Tab::Get[Title|Icon]Bounds helpers. Update the text on Tab::SetData, not during paint. Use gfx::DirectionalityMode, remove the Label enum. Add gfx::ALIGN_TO_HEAD to gfx::HorizontalAlignment. Add Label::GetHorizontalAlignment for ALIGN_TO_HEAD. Always flip left/right in Label::SetHorizontalAlignment. Have Tab and MessageBoxView use ALIGN_TO_HEAD. Update comments and tests, related minor cleanup. TODO: Make Label cache RenderText objects. TODO: Make RenderText support ALIGN_TO_HEAD. BUG=240037 TEST=No visible Views tab title changes. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276566

Patch Set 1 #

Patch Set 2 : Call AddChildView(title_) on Tab to prevent leaks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5280 lines, -5337 lines) Patch
M chrome/browser/ui/views/tabs/tab.h View 1 chunk +370 lines, -378 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 1 chunk +1634 lines, -1656 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_unittest.cc View 1 1 chunk +298 lines, -295 lines 0 comments Download
M chrome/browser/ui/views/validation_message_bubble_delegate.cc View 1 chunk +102 lines, -103 lines 0 comments Download
M ui/gfx/text_constants.h View 1 chunk +57 lines, -56 lines 0 comments Download
M ui/message_center/views/bounded_label.cc View 1 chunk +360 lines, -357 lines 0 comments Download
M ui/views/controls/button/label_button.cc View 1 chunk +438 lines, -438 lines 0 comments Download
M ui/views/controls/label.h View 1 chunk +270 lines, -305 lines 0 comments Download
M ui/views/controls/label.cc View 1 chunk +572 lines, -564 lines 0 comments Download
M ui/views/controls/label_unittest.cc View 1 chunk +908 lines, -906 lines 0 comments Download
M ui/views/controls/message_box_view.cc View 1 chunk +271 lines, -279 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
msw
Hey Scott, please take a look; thanks!
6 years, 6 months ago (2014-06-11 20:20:11 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-11 20:29:56 UTC) #2
msw
The CQ bit was checked by msw@chromium.org
6 years, 6 months ago (2014-06-11 20:31:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/329813003/20001
6 years, 6 months ago (2014-06-11 20:36:02 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 22:00:09 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:18:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_dbg/builds/31399)
6 years, 6 months ago (2014-06-11 22:18:23 UTC) #7
msw
The CQ bit was checked by msw@chromium.org
6 years, 6 months ago (2014-06-12 03:32:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/329813003/20001
6 years, 6 months ago (2014-06-12 03:33:32 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 07:41:51 UTC) #10
Message was sent while issue was closed.
Change committed as 276566

Powered by Google App Engine
This is Rietveld 408576698