Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1707)

Unified Diff: Source/platform/BUILD.gn

Issue 329813002: GN: Depend on actual v8, not a stub target (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/BUILD.gn ('K') | « Source/core/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/BUILD.gn
diff --git a/Source/platform/BUILD.gn b/Source/platform/BUILD.gn
index ff51e4667e30b6008c1982a162bcec201c16c793..8d8fd44924c37ffa5049a9a14588bdd0c3e3978d 100644
--- a/Source/platform/BUILD.gn
+++ b/Source/platform/BUILD.gn
@@ -173,7 +173,6 @@ component("platform") {
get_target_outputs(":color_data")
configs += [
- ":v8_stub_config",
"//third_party/WebKit/Source:config",
"//third_party/WebKit/Source:non_test_config",
]
@@ -206,9 +205,7 @@ component("platform") {
"//third_party/WebKit/Source/platform/heap",
"//url",
#'blink_heap_asm_stubs',
- # TODO(GYP) also remove v8_stub_config when this is added, and uncomment
- # V8 in the forward statement below.
- #"//v8",
+ "//v8",
]
forward_dependent_configs_from = [
@@ -221,8 +218,7 @@ component("platform") {
"//third_party/ots",
"//third_party/qcms",
"//url",
- # TODO(GYP)
- #"//v8",
+ "//v8",
]
if (is_mac) {
@@ -459,9 +455,3 @@ if (cpu_arch == "arm") {
deps = [ ":blink_common" ]
}
}
-
-# This config is a placeholder to set up the V8 include path while the V8 GN
-# build is being worked on.
-config("v8_stub_config") {
- include_dirs = [ "//v8/include" ]
-}
« Source/core/BUILD.gn ('K') | « Source/core/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698