Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 329813002: GN: Depend on actual v8, not a stub target (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
blink-reviews
Visibility:
Public.

Description

GN: Depend on actual v8, not a stub target V8 has GN build files now, we don't need this stub any more. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176045

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M Source/core/BUILD.gn View 3 chunks +0 lines, -4 lines 1 comment Download
M Source/platform/BUILD.gn View 1 4 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jamesr
https://codereview.chromium.org/329813002/diff/20001/Source/core/BUILD.gn File Source/core/BUILD.gn (left): https://codereview.chromium.org/329813002/diff/20001/Source/core/BUILD.gn#oldcode171 Source/core/BUILD.gn:171: "//third_party/WebKit/Source/platform:v8_stub_config", these might need to forward v8, but i ...
6 years, 6 months ago (2014-06-11 20:03:09 UTC) #1
brettw
lgtm
6 years, 6 months ago (2014-06-11 20:12:12 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-11 20:15:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/329813002/20001
6 years, 6 months ago (2014-06-11 20:15:40 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-11 21:20:12 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:23:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15653)
6 years, 6 months ago (2014-06-11 21:23:46 UTC) #7
jamesr
On 2014/06/11 21:23:46, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 6 months ago (2014-06-11 22:02:12 UTC) #8
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-12 18:01:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/329813002/20001
6 years, 6 months ago (2014-06-12 18:02:14 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 21:24:11 UTC) #11
Message was sent while issue was closed.
Change committed as 176045

Powered by Google App Engine
This is Rietveld 408576698