Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 329803002: Fix text input. (Closed)

Created:
6 years, 6 months ago by Ben Goodger (Google)
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Fix text input. The mock input method wasn't filtering WM_CHARs. R=sky@chromium.org http://crbug.com/365012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276700

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -41 lines) Patch
M mojo/views/native_widget_view_manager.cc View 1 2 3 2 chunks +5 lines, -41 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Ben Goodger (Google)
6 years, 6 months ago (2014-06-11 19:56:59 UTC) #1
sky
LGTM https://codereview.chromium.org/329803002/diff/20001/mojo/views/native_widget_view_manager.cc File mojo/views/native_widget_view_manager.cc (right): https://codereview.chromium.org/329803002/diff/20001/mojo/views/native_widget_view_manager.cc#newcode15 mojo/views/native_widget_view_manager.cc:15: #include "ui/base/ime/mock_input_method.h" nit: I think you can remove ...
6 years, 6 months ago (2014-06-11 20:00:37 UTC) #2
Ben Goodger (Google)
Had to change it to input_method.h
6 years, 6 months ago (2014-06-11 20:34:25 UTC) #3
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 6 months ago (2014-06-11 20:34:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/329803002/40001
6 years, 6 months ago (2014-06-11 20:36:01 UTC) #5
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 6 months ago (2014-06-11 20:45:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/329803002/60001
6 years, 6 months ago (2014-06-11 20:48:49 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 22:13:30 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:23:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/160394) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/149807) ios_rel_device_ninja ...
6 years, 6 months ago (2014-06-11 22:23:04 UTC) #10
Ben Goodger (Google)
6 years, 6 months ago (2014-06-12 16:30:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 manually as r276700 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698