Omnibox: append old matches, don't attempt to insert them

Omnibox: append old matches, don't attempt to insert them

Make AddMatch() append old matches rather than attempt to insert them
in order.  We call SortAndCull() after AddMatch() in the only code
path that uses AddMatch(), so the order doesn't matter.

Then eliminate AddMatch() because the revised version is short,
instead inlining the few things it still does in its only caller.

In some quick interactive testing, I didn't notice any problems.

The autocomplete_result tests still pass also.  (That said, I don't
think we test CopyOldMatches that extensively in it.)

BUG=380357
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276714

[Mark P, 2014-06-11 19:17:17]

I think this is safe, but as I note in the changelist description this behavior
isn't well tested or easy to test.  If you have any concerns, tell me.

--mark

[Peter Kasting, 2014-06-11 20:06:43]

LGTM

https://codereview.chromium.org/329783003/diff/1/chrome/browser/autocomplete/...
File chrome/browser/autocomplete/autocomplete_result.cc (right):

https://codereview.chromium.org/329783003/diff/1/chrome/browser/autocomplete/...
chrome/browser/autocomplete/autocomplete_result.cc:450: match.description);
I don't think these two DCHECKs are necessary.  We will have already checked
this when these matches were originally inserted into a result set in
AutocompleteController::UpdateResult().

[Mark P, 2014-06-11 21:40:45]

https://codereview.chromium.org/329783003/diff/1/chrome/browser/autocomplete/...
File chrome/browser/autocomplete/autocomplete_result.cc (right):

https://codereview.chromium.org/329783003/diff/1/chrome/browser/autocomplete/...
chrome/browser/autocomplete/autocomplete_result.cc:450: match.description);
On 2014/06/11 20:06:43, Peter Kasting wrote:
> I don't think these two DCHECKs are necessary.  We will have already checked
> this when these matches were originally inserted into a result set in
> AutocompleteController::UpdateResult().

Done.

[Mark P, 2014-06-11 21:40:48]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:43:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mpearson@chromium.org/329783003/20001

[commit-bot: I haz the power, 2014-06-11 23:11:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15683)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18817)

[commit-bot: I haz the power, 2014-06-11 23:13:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 23:13:20]

Try jobs failed on following builders:
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15763)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18895)

[Mark P, 2014-06-12 14:29:12]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2014-06-12 14:31:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mpearson@chromium.org/329783003/20001

[commit-bot: I haz the power, 2014-06-12 16:54:44]

Change committed as 276714