Source/core/rendering/RenderObject.h - Issue 329773002: Remove special touch-action hit test mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderObject.h

Issue 329773002: Remove special touch-action hit test mode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporated review comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderObject.h

diff --git a/Source/core/rendering/RenderObject.h b/Source/core/rendering/RenderObject.h

index e696a29c813d8c98b9258575c86151668ffe76d7..d6e3b6a794947038c83b7d940ab7557a2cdf06fa 100644

--- a/Source/core/rendering/RenderObject.h

+++ b/Source/core/rendering/RenderObject.h

@@ -949,14 +949,9 @@ public:

bool isInert() const;

- bool visibleForTouchAction() const;

+ bool supportsTouchAction() const;

- bool visibleToHitTestRequest(const HitTestRequest& request) const

- {

- if (request.touchAction() && !visibleForTouchAction())

- return false;

- return style()->visibility() == VISIBLE && (request.ignorePointerEventsNone() || style()->pointerEvents() != PE_NONE) && !isInert();

- }

+ bool visibleToHitTestRequest(const HitTestRequest& request) const { return style()->visibility() == VISIBLE && (request.ignorePointerEventsNone() || style()->pointerEvents() != PE_NONE) && !isInert(); }

bool visibleToHitTesting() const { return style()->visibility() == VISIBLE && style()->pointerEvents() != PE_NONE && !isInert(); }

« no previous file with comments | « Source/core/rendering/InlineBox.h ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »