Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: Source/core/rendering/RenderObject.cpp

Issue 329773002: Remove special touch-action hit test mode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: incorporated review comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderObject.h ('k') | Source/web/tests/data/touch-action-simple.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 3302 matching lines...) Expand 10 before | Expand all | Expand 10 after
3313 const RenderObject* renderer = this; 3313 const RenderObject* renderer = this;
3314 while (!renderer->node()) 3314 while (!renderer->node())
3315 renderer = renderer->parent(); 3315 renderer = renderer->parent();
3316 return renderer->node()->isInert(); 3316 return renderer->node()->isInert();
3317 } 3317 }
3318 3318
3319 // touch-action applies to all elements with both width AND height properties. 3319 // touch-action applies to all elements with both width AND height properties.
3320 // According to the CSS Box Model Spec (http://dev.w3.org/csswg/css-box/#the-wid th-and-height-properties) 3320 // According to the CSS Box Model Spec (http://dev.w3.org/csswg/css-box/#the-wid th-and-height-properties)
3321 // width applies to all elements but non-replaced inline elements, table rows, a nd row groups and 3321 // width applies to all elements but non-replaced inline elements, table rows, a nd row groups and
3322 // height applies to all elements but non-replaced inline elements, table column s, and column groups. 3322 // height applies to all elements but non-replaced inline elements, table column s, and column groups.
3323 bool RenderObject::visibleForTouchAction() const 3323 bool RenderObject::supportsTouchAction() const
3324 { 3324 {
3325 if (isInline() && !isReplaced()) 3325 if (isInline() && !isReplaced())
3326 return false; 3326 return false;
3327 if (isTableRow() || isRenderTableCol()) 3327 if (isTableRow() || isRenderTableCol())
3328 return false; 3328 return false;
3329 3329
3330 return true; 3330 return true;
3331 } 3331 }
3332 3332
3333 void RenderObject::imageChanged(ImageResource* image, const IntRect* rect) 3333 void RenderObject::imageChanged(ImageResource* image, const IntRect* rect)
(...skipping 226 matching lines...) Expand 10 before | Expand all | Expand 10 after
3560 { 3560 {
3561 if (object1) { 3561 if (object1) {
3562 const WebCore::RenderObject* root = object1; 3562 const WebCore::RenderObject* root = object1;
3563 while (root->parent()) 3563 while (root->parent())
3564 root = root->parent(); 3564 root = root->parent();
3565 root->showRenderTreeAndMark(object1, "*", object2, "-", 0); 3565 root->showRenderTreeAndMark(object1, "*", object2, "-", 0);
3566 } 3566 }
3567 } 3567 }
3568 3568
3569 #endif 3569 #endif
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderObject.h ('k') | Source/web/tests/data/touch-action-simple.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698