Update file extension based on the selected type in the save dialog.

Update file extension based on the selected type in the save dialog.

Along the way, it fixes the filter regexp so that ("txt") will
not match "foo.xtxt", etc.

BUG=373659
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276430

[hirono, 2014-06-11 07:14:05]

Thank you for fixing it!

https://codereview.chromium.org/329763003/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/file_manager.js (right):

https://codereview.chromium.org/329763003/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/file_manager.js:1360: if (newExt &&
!regexp.test(current)) {
Maybe we can do just:
if (newExt) {
  this.filenameInput_.value = current.replace(regexp, '.' + newExt);
  this.selectTargetNameInFilenameInput_();
}

[kinaba, 2014-06-11 07:23:44]

https://codereview.chromium.org/329763003/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/file_manager.js (right):

https://codereview.chromium.org/329763003/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/file_manager.js:1360: if (newExt &&
!regexp.test(current)) {
On 2014/06/11 07:14:05, hirono wrote:
> Maybe we can do just:
> if (newExt) {
>   this.filenameInput_.value = current.replace(regexp, '.' + newExt);
>   this.selectTargetNameInFilenameInput_();
> }

Unfortunately not. |regexp| matches with the new extension,
while what we want to replace in |current| is the old extension
that did not match |regexp|.

[hirono, 2014-06-11 07:28:54]

On 2014/06/11 07:23:44, kinaba wrote:
>
https://codereview.chromium.org/329763003/diff/1/ui/file_manager/file_manager...
> File ui/file_manager/file_manager/foreground/js/file_manager.js (right):
> 
>
https://codereview.chromium.org/329763003/diff/1/ui/file_manager/file_manager...
> ui/file_manager/file_manager/foreground/js/file_manager.js:1360: if (newExt &&
> !regexp.test(current)) {
> On 2014/06/11 07:14:05, hirono wrote:
> > Maybe we can do just:
> > if (newExt) {
> >   this.filenameInput_.value = current.replace(regexp, '.' + newExt);
> >   this.selectTargetNameInFilenameInput_();
> > }
> 
> Unfortunately not. |regexp| matches with the new extension,
> while what we want to replace in |current| is the old extension
> that did not match |regexp|.

Ah, yes. Thank you for explanation. lgtm!

[kinaba, 2014-06-11 07:29:31]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-06-11 07:30:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kinaba@chromium.org/329763003/1

[commit-bot: I haz the power, 2014-06-11 16:32:16]

Change committed as 276430