Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: net/http/disk_based_cert_cache.h

Issue 329733002: Disk Based Certificate Cache Implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed memory leak by remembering to close entry and free OSCertHandle. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/disk_based_cert_cache.cc » ('j') | net/http/disk_based_cert_cache_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/disk_based_cert_cache.h
diff --git a/net/http/disk_based_cert_cache.h b/net/http/disk_based_cert_cache.h
new file mode 100644
index 0000000000000000000000000000000000000000..302ac5cf7fe7a8d7aa259a4d36aac1b7ced5abd2
--- /dev/null
+++ b/net/http/disk_based_cert_cache.h
@@ -0,0 +1,74 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_HTTP_DISK_BASED_CERT_CACHE_H
+#define NET_HTTP_DISK_BASED_CERT_CACHE_H
+
+#include <string>
+
+#include "base/callback.h"
+#include "base/containers/hash_tables.h"
+#include "base/memory/weak_ptr.h"
+#include "net/base/net_export.h"
+#include "net/cert/x509_certificate.h"
+
+namespace disk_cache {
+class Backend;
+} // namespace disk_cache
+
+namespace net {
+
+// DiskBasedCertCache is used to store and retrieve X.509 certificates from the
+// cache. Each individual certificate is stored separately from its certificate
+// chain. No more than one copy (per certificate) will be stored on disk.
+class NET_EXPORT_PRIVATE DiskBasedCertCache {
+ public:
+ typedef base::Callback<void(const X509Certificate::OSCertHandle cert_handle)>
+ GetCallback;
+ typedef base::Callback<void(const std::string&)> SetCallback;
+
+ // Initializes a new DiskBasedCertCache that will use |backend|, which has
+ // previously been initialized, to store the certificate in the cache.
+ explicit DiskBasedCertCache(disk_cache::Backend* backend);
+ ~DiskBasedCertCache();
+
+ // Fetches the certificate associated with |key|. If the certificate is
+ // found within the cache, |cb| will be called with the certificate.
+ // Otherwise, |cb| will be called with NULL. Callers that wish to store
+ // a reference to the certificate need to use X509Certificate::DupOSCertHandle
+ // inside |cb|.
+ void Get(const std::string& key, const GetCallback& cb);
+
+ // Stores |cert_handle| in the cache. If |cert_handle| is successfully stored,
+ // |cb| will be called with the key. If |cb| is called with an empty
+ // string, then |cert_handle| was not stored.
+ void Set(const X509Certificate::OSCertHandle cert_handle,
+ const SetCallback& cb);
+
+ private:
+ class ReadWorker;
+ class WriteWorker;
+
+ // ReadWorkerMap and WriteWorkerMap map cache keys to their
+ // corresponding Workers.
+ typedef base::hash_map<std::string, ReadWorker*> ReadWorkerMap;
+ typedef base::hash_map<std::string, WriteWorker*> WriteWorkerMap;
+
+ // FinishedReadOperation and FinishedWriteOperation are used by callbacks
+ // given to the workers to signal the DiskBasedCertCache they have completed
+ // their work.
+ void FinishedReadOperation(const std::string& key);
+ void FinishedWriteOperation(const std::string& key);
+
+ ReadWorkerMap read_worker_map_;
+ WriteWorkerMap write_worker_map_;
+
+ disk_cache::Backend* backend_;
+ base::WeakPtrFactory<DiskBasedCertCache> weak_factory_;
+ DISALLOW_COPY_AND_ASSIGN(DiskBasedCertCache);
+};
+
+} // namespace net
+
+#endif // NET_HTTP_DISK_BASED_CERT_CACHE_H
« no previous file with comments | « no previous file | net/http/disk_based_cert_cache.cc » ('j') | net/http/disk_based_cert_cache_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698