Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 329703002: Merge appendChildToContainer into ContainerNode (Closed)

Created:
6 years, 6 months ago by esprehn
Modified:
6 years, 6 months ago
Reviewers:
ojan, abarth-chromium
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Visibility:
Public.

Description

Merge appendChildToContainer into ContainerNode We don't need the templates in ContainerNodeAlgorithms now, lets start merging them into ContainerNode. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175968

Patch Set 1 #

Patch Set 2 : typo #

Patch Set 3 : try again #

Patch Set 4 : try again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -23 lines) Patch
M Source/core/dom/ContainerNode.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 2 3 4 chunks +17 lines, -4 lines 0 comments Download
M Source/core/dom/ContainerNodeAlgorithms.h View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
esprehn
6 years, 6 months ago (2014-06-11 16:59:56 UTC) #1
ojan
lgtm
6 years, 6 months ago (2014-06-11 17:44:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/329703002/60001
6 years, 6 months ago (2014-06-11 17:45:44 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 17:58:24 UTC) #4
Message was sent while issue was closed.
Change committed as 175968

Powered by Google App Engine
This is Rietveld 408576698