Improvements in --debug-print switch implementation.

printing/printed_document.h

Index: printing/printed_document.h
diff --git a/printing/printed_document.h b/printing/printed_document.h
index b8af4bb5f39e4984cf98d0d4278f7dc222176bd4..ee07ae0af4869cf281ff40acda76e97746ce6bd7 100644
--- a/printing/printed_document.h
+++ b/printing/printed_document.h
@@ -48,7 +48,7 @@ class PRINTING_EXPORT PrintedDocument
   // Retrieves a page. If the page is not available right now, it
   // requests to have this page be rendered and returns false.

[Lei Zhang, 2014/06/11 20:03:06]

update comment

[Vitaly Buka (NO REVIEWS), 2014/06/11 21:32:58]

Done.

   // Note: locks for a short amount of time.
-  bool GetPage(int page_number, scoped_refptr<PrintedPage>* page);
+  scoped_refptr<PrintedPage> GetPage(int page_number);
 
   // Draws the page in the context.
   // Note: locks for a short amount of time in debug only.
@@ -97,7 +97,11 @@ class PRINTING_EXPORT PrintedDocument
   // no files are generated.
   static void set_debug_dump_path(const base::FilePath& debug_dump_path);
 
-  static const base::FilePath& debug_dump_path();
+  // Creates debug file name from given |document_name| and |extension|.
+  // Returns empty |base::FilePath| if |set_debug_dump_path| was not yet called
+  // or called with empty value.
+  static base::FilePath CreateDebugDumpPath(const base::string16& document_name,
+                                            const std::string& extension);
 
  private:
   friend class base::RefCountedThreadSafe<PrintedDocument>;
@@ -160,6 +164,7 @@ class PRINTING_EXPORT PrintedDocument
     int cookie_;
   };
 
+  void DebugDumpSettings();
   void DebugDump(const PrintedPage& page);
 
   // All writable data member access must be guarded by this lock. Needs to be