Improvements in --debug-print switch implementation.

chrome/browser/printing/print_view_manager_base.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/print_view_manager_base.h"
 
 #include <map>
 
 #include "base/bind.h"
+#include "base/file_util.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/numerics/safe_conversions.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/timer/timer.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/printing/print_job.h"
 #include "chrome/browser/printing/print_job_manager.h"
 #include "chrome/browser/printing/printer_query.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/simple_message_box.h"
@@ skipping 22 matching lines @@
 #if defined(WIN_PDF_METAFILE_FOR_PRINTING)
 #include "base/memory/ref_counted.h"
 #include "base/memory/ref_counted_memory.h"
 #include "chrome/browser/printing/pdf_to_emf_converter.h"
 #include "printing/pdf_render_settings.h"
 #endif
 
 using base::TimeDelta;
 using content::BrowserThread;
 
+namespace printing {
+
+namespace {
+
 #if defined(OS_WIN) && !defined(WIN_PDF_METAFILE_FOR_PRINTING)
 // Limits memory usage by raster to 64 MiB.
 const int kMaxRasterSizeInPixels = 16*1024*1024;
 #endif
 
-namespace printing {
+#if defined(WIN_PDF_METAFILE_FOR_PRINTING)
+void WriteBytesOnFileThread(const base::FilePath& path,
+                            const base::RefCountedMemory* deta) {
+  base::WriteFile(path,
+                  reinterpret_cast<const char*>(deta->front()),
+                  base::checked_cast<int>(deta->size()));
+}
+#endif  // WIN_PDF_METAFILE_FOR_PRINTING
+
+}  // namespace
 
 PrintViewManagerBase::PrintViewManagerBase(content::WebContents* web_contents)
     : content::WebContentsObserver(web_contents),
       number_pages_(0),
       printing_succeeded_(false),
       inside_inner_message_loop_(false),
       cookie_(0),
       queue_(g_browser_process->print_job_manager()->queue()) {
   DCHECK(queue_);
 #if (defined(OS_POSIX) && !defined(OS_MACOSX)) || \
@@ skipping 144 matching lines @@
       TerminatePrintJob(true);
       web_contents()->Stop();
       return;
     }
   }
 #endif  // OS_WIN && !WIN_PDF_METAFILE_FOR_PRINTING
 
 #if !defined(WIN_PDF_METAFILE_FOR_PRINTING)
   // Update the rendered document. It will send notifications to the listener.
   document->SetPage(params.page_number,
-    metafile.release(),
-    params.actual_shrink,
-    params.page_size,
-    params.content_area);
+                    metafile.release(),
+                    params.actual_shrink,
+                    params.page_size,
+                    params.content_area);
 
   ShouldQuitFromInnerMessageLoop();
 #else
   if (metafile_must_be_valid) {
     scoped_refptr<base::RefCountedBytes> bytes = new base::RefCountedBytes(
         reinterpret_cast<const unsigned char*>(shared_buf.memory()),
         params.data_size);
 
+    base::FilePath debug_dump_path =
+        PrintedDocument::CreateDebugDumpPath(document->name(), "pdf");
+    if (!debug_dump_path.empty()) {
+      BrowserThread::PostTask(
+          BrowserThread::FILE,
+          FROM_HERE,
+          base::Bind(&WriteBytesOnFileThread, debug_dump_path, bytes));

[Lei Zhang, 2014/06/11 20:03:05]

You can probably Bind() to &base::WriteFile with IgnoreResult() directly.

[Vitaly Buka (NO REVIEWS), 2014/06/11 21:32:57]

Moved writing into document.

+    }

[Noam Samuel, 2014/06/11 18:35:23]

Does this only dump PDFS on Windows? Maybe it makes sense to dump PDFs on all
platforms?

(Feel free to ignore this comment if it's too much work/not needed)

[Vitaly Buka (NO REVIEWS), 2014/06/11 21:32:57]

Other platforms dumped pdfs inside of SetPage above.
Code is moved to GetPage, because it called on FILE thread.

+
     if (!pdf_to_emf_converter_)
       pdf_to_emf_converter_ = PdfToEmfConverter::CreateDefault();
 
     const int kPrinterDpi = 600;
     pdf_to_emf_converter_->Start(
         bytes,
         printing::PdfRenderSettings(params.content_area, kPrinterDpi, false),
         base::Bind(&PrintViewManagerBase::OnPdfToEmfConverted,
                    base::Unretained(this),
                    params));
@@ skipping 343 matching lines @@
   scoped_refptr<printing::PrinterQuery> printer_query;
   printer_query = queue_->PopPrinterQuery(cookie);
   if (!printer_query)
     return;
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&PrinterQuery::StopWorker, printer_query.get()));
 }
 
 }  // namespace printing