[webcrypto] Restrict public exponent for RSA key generation to 3 or 65537.

[webcrypto] Restrict public exponent for RSA key generation to 3 or 65537.

OpenSSL can hang when given invalid values for the public exponent so do a whitelist validation approach to avoid this.

For compatibility reasons the same restriction is applied to the NSS implementation.

BUG=381844, 245025
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276658

[Ryan Sleevi, 2014-06-10 23:46:44]

LGTM % bug.

https://codereview.chromium.org/329673002/diff/1/content/child/webcrypto/shar...
File content/child/webcrypto/shared_crypto.cc (right):

https://codereview.chromium.org/329673002/diff/1/content/child/webcrypto/shar...
content/child/webcrypto/shared_crypto.cc:610: // mean value 0? See
https://www.w3.org/Bugs/Public/show_bug.cgi?id=23655
This was answered upstream. Can you please fix this here, as it's a bug.

[eroman, 2014-06-11 01:13:10]

https://codereview.chromium.org/329673002/diff/1/content/child/webcrypto/shar...
File content/child/webcrypto/shared_crypto.cc (right):

https://codereview.chromium.org/329673002/diff/1/content/child/webcrypto/shar...
content/child/webcrypto/shared_crypto.cc:610: // mean value 0? See
https://www.w3.org/Bugs/Public/show_bug.cgi?id=23655
On 2014/06/10 23:46:44, Ryan Sleevi wrote:
> This was answered upstream. Can you please fix this here, as it's a bug.

Yup I am aware of that (http://crbug.com/373552).

I am not going to address that here, it requires some changes on Blink side
first.

This is strictly moving a function.

[eroman, 2014-06-11 21:57:23]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:58:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/329673002/1

[commit-bot: I haz the power, 2014-06-11 23:20:37]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15699)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18832)

[commit-bot: I haz the power, 2014-06-11 23:23:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 23:23:10]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[eroman, 2014-06-12 00:02:41]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-06-12 00:04:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/329673002/1

[commit-bot: I haz the power, 2014-06-12 00:42:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15801)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18934)

[commit-bot: I haz the power, 2014-06-12 00:44:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-12 00:44:08]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15826)

[eroman, 2014-06-12 00:56:35]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-06-12 00:57:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/329673002/1

[commit-bot: I haz the power, 2014-06-12 13:21:52]

Change committed as 276658