Media Galleries: Allow readding blacklisted iApps libraries.

chrome/browser/media_galleries/media_galleries_preferences_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // MediaGalleriesPreferences unit tests.
 
 #include "chrome/browser/media_galleries/media_galleries_preferences.h"
 
 #include "base/command_line.h"
 #include "base/memory/ref_counted.h"
@@ skipping 1068 matching lines @@
   expected_galleries_.erase(user_added_id);
   expected_device_map[info.device_id()].erase(user_added_id);
 
   EXPECT_EQ(2, observer1.notifications());
   EXPECT_EQ(3, observer2.notifications());
 }
 
 TEST_F(MediaGalleriesPreferencesTest, UpdateSingletonDeviceIdType) {
   MediaGalleryPrefId id;
   base::FilePath path;
-  StorageInfo info;
-  base::FilePath relative_path;
   Verify();
 
   // Add a new auto detect gallery to test with.
   path = MakeMediaGalleriesTestingPath("new_auto");
-  MediaStorageUtil::GetDeviceInfoFromPath(path, &info, &relative_path);
   base::string16 gallery_name = base::ASCIIToUTF16("NewAutoGallery");
-  info.set_device_id(StorageInfo::MakeDeviceId(StorageInfo::ITUNES,
-                                               path.AsUTF8Unsafe()));
-  id = AddGalleryWithNameV2(info.device_id(), gallery_name, relative_path,
+  std::string device_id = StorageInfo::MakeDeviceId(StorageInfo::ITUNES,
+                                                    path.AsUTF8Unsafe());
+  id = AddGalleryWithNameV2(device_id, gallery_name, base::FilePath(),
                             MediaGalleryPrefInfo::kAutoDetected);
   EXPECT_EQ(default_galleries_count() + 1UL, id);
-  AddGalleryExpectation(id, gallery_name, info.device_id(), relative_path,
+  AddGalleryExpectation(id, gallery_name, device_id, base::FilePath(),
                         MediaGalleryPrefInfo::kAutoDetected);
   Verify();
 
   // Update the device id.
   MockGalleryChangeObserver observer(gallery_prefs());
   gallery_prefs()->AddGalleryChangeObserver(&observer);
 
   path = MakeMediaGalleriesTestingPath("updated_path");
   std::string updated_device_id =
       StorageInfo::MakeDeviceId(StorageInfo::ITUNES, path.AsUTF8Unsafe());
   EXPECT_TRUE(UpdateDeviceIDForSingletonType(updated_device_id));
-  AddGalleryExpectation(id, gallery_name, updated_device_id, relative_path,
+  AddGalleryExpectation(id, gallery_name, updated_device_id, base::FilePath(),
                         MediaGalleryPrefInfo::kAutoDetected);
-  expected_device_map[info.device_id()].erase(id);
+  expected_device_map[device_id].erase(id);
   expected_device_map[updated_device_id].insert(id);
   Verify();
   EXPECT_EQ(1, observer.notifications());
 
   // No gallery for type.
   std::string new_device_id =
       StorageInfo::MakeDeviceId(StorageInfo::PICASA, path.AsUTF8Unsafe());
   EXPECT_FALSE(UpdateDeviceIDForSingletonType(new_device_id));
 }
 
+TEST_F(MediaGalleriesPreferencesTest, LookupImportedGalleryByPath) {
+  MediaGalleryPrefId id;
+  base::FilePath path;
+  Verify();
+
+  // iTunes device path points to an XML file in the library directory.
+  path = MakeMediaGalleriesTestingPath("new_auto").AppendASCII("library.xml");
+  base::string16 gallery_name = base::ASCIIToUTF16("NewAutoGallery");
+  std::string device_id = StorageInfo::MakeDeviceId(StorageInfo::ITUNES,
+                                                    path.AsUTF8Unsafe());
+  id = AddGalleryWithNameV2(device_id, gallery_name, base::FilePath(),
+                            MediaGalleryPrefInfo::kAutoDetected);
+  EXPECT_EQ(default_galleries_count() + 1UL, id);
+  AddGalleryExpectation(id, gallery_name, device_id, base::FilePath(),
+                        MediaGalleryPrefInfo::kAutoDetected);
+  Verify();
+
+  // Verify we can look up the imported gallery by its path.
+  MediaGalleryPrefInfo gallery_info;
+  EXPECT_TRUE(gallery_prefs()->LookUpGalleryByPath(path.DirName(),
+                                                   &gallery_info));
+  EXPECT_EQ(id, gallery_info.pref_id);
+}
+
 TEST_F(MediaGalleriesPreferencesTest, ScanResults) {
   MediaGalleryPrefId id;
   base::FilePath path;
   StorageInfo info;
   base::FilePath relative_path;
   base::Time now = base::Time::Now();
   Verify();
 
   // Add a new scan result gallery to test with.
   path = MakeMediaGalleriesTestingPath("new_scan");
@@ skipping 84 matching lines @@
   info.volume_label = base::string16();
   EXPECT_EQ(ASCIIToUTF16("vendor, model"), info.GetGalleryDisplayName());
 
   info.device_id = StorageInfo::MakeDeviceId(
       StorageInfo::FIXED_MASS_STORAGE, "unique");
   EXPECT_EQ(base::FilePath(FILE_PATH_LITERAL("unique")).AsUTF8Unsafe(),
             base::UTF16ToUTF8(info.GetGalleryTooltip()));
 
   TestStorageMonitor::Destroy();
 }