Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: pkg/analysis_server/lib/src/index/page_node_manager.dart

Issue 329633002: Some clean ups for caching tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/index/page_node_manager.dart
diff --git a/pkg/analysis_server/lib/src/index/page_node_manager.dart b/pkg/analysis_server/lib/src/index/page_node_manager.dart
index 75c37404de53b8916555b82d0920d747c5b2991e..5e19f49a5c29dc2bd3a9604a31d65d38283d870a 100644
--- a/pkg/analysis_server/lib/src/index/page_node_manager.dart
+++ b/pkg/analysis_server/lib/src/index/page_node_manager.dart
@@ -22,19 +22,10 @@ class CachingNodeManager<K, V, N> implements NodeManager<K, V, N> {
CachingNodeManager(this._delegate, int indexNodeCacheSize,
int leafNodeCacheSize) {
- // TODO(scheglov) method pointers don't work with mocks
-// _indexCache = new LRUCache<N, IndexNodeData<K, N>>(indexNodeCacheSize,
-// _delegate.writeIndex);
-// _leafCache = new LRUCache<N, LeafNodeData<K, V>>(leafNodeCacheSize,
-// _delegate.writeLeaf);
_indexCache = new LRUCache<N, IndexNodeData<K, N>>(indexNodeCacheSize,
- (N key, IndexNodeData<K, N> value) {
- _delegate.writeIndex(key, value);
- });
- _leafCache = new LRUCache<N, LeafNodeData<K, V>>(leafNodeCacheSize, (N key,
- LeafNodeData<K, V> value) {
- _delegate.writeLeaf(key, value);
- });
+ _delegate.writeIndex);
+ _leafCache = new LRUCache<N, LeafNodeData<K, V>>(leafNodeCacheSize,
+ _delegate.writeLeaf);
}
@override
« no previous file with comments | « pkg/analysis_server/lib/src/index/lru_cache.dart ('k') | pkg/analysis_server/test/index/lru_cache_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698