Some clean ups for caching tests.

pkg/analysis_server/test/index/page_node_manager_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.index.page_node_manager;
 
 import 'dart:math';
 import 'dart:typed_data';
 
 import 'package:analysis_server/src/index/b_plus_tree.dart';
@@ skipping 65 matching lines @@
   }
   // find every remaining key
   for (int key in keys) {
     expect(tree.find(key), 'V$key');
   }
 }
 
 
 @ReflectiveTestCase()
 class _CachingNodeManagerTest {
-  NodeManager<int, String, int> delegate = new _NodeManagerMock<int, String, int>();
+  _NodeManagerMock<int, String, int> delegate = new _NodeManagerMock<int,
+      String, int>();
   NodeManager<int, String, int> manager;
 
   void setUp() {
+    when(delegate.writeIndex).thenReturn((key, value) {
+      delegate.writeIndex(key, value);
+    });
+    when(delegate.writeLeaf).thenReturn((key, value) {
+      delegate.writeLeaf(key, value);
+    });
     manager = new CachingNodeManager<int, String, int>(delegate, 4, 4);
+    resetInteractions(delegate);
   }
 
   void test_maxIndexKeys() {
     when(delegate.maxIndexKeys).thenReturn(42);
     expect(manager.maxIndexKeys, 42);
   }
 
   void test_maxLeafKeys() {
     when(delegate.maxLeafKeys).thenReturn(42);
     expect(manager.maxLeafKeys, 42);
@@ skipping 53 matching lines @@
     expect(manager.readLeaf(2), data);
   }
 
   void test_writeIndex() {
     var data = new IndexNodeData<int, int>([1], [10, 20]);
     manager.writeIndex(1, data);
     manager.writeIndex(2, data);
     manager.writeIndex(3, data);
     manager.writeIndex(4, data);
     manager.writeIndex(1, data);
-    // TODO(scheglov) method pointers don't work with mocks
-    // TODO(scheglov) add resetInteractions(mock)
-    // TODO(scheglov) verifyZeroInteractions() should accept 'dynamic'
-//    verifyZeroInteractions(delegate as TypedMock);
-    verify(delegate.writeIndex(anyInt, anyObject)).never();
+    verifyZeroInteractions(delegate);
     // only 4 nodes can be cached, 5-th one cause write to the delegate
     manager.writeIndex(5, data);
     verify(delegate.writeIndex(2, data)).once();
   }
 
   void test_writeLeaf() {
     var data = new LeafNodeData<int, String>([1, 2], ['A', 'B']);
     manager.writeLeaf(1, data);
     manager.writeLeaf(2, data);
     manager.writeLeaf(3, data);
     manager.writeLeaf(4, data);
     manager.writeLeaf(1, data);
-    // TODO(scheglov) method pointers don't work with mocks
-    // TODO(scheglov) add resetInteractions(mock)
-    // TODO(scheglov) verifyZeroInteractions() should accept 'dynamic'
-//    verifyZeroInteractions(delegate as TypedMock);
-    verify(delegate.writeLeaf(anyInt, anyObject)).never();
+    verifyZeroInteractions(delegate);
     // only 4 nodes can be cached, 5-th one cause write to the delegate
     manager.writeLeaf(5, data);
     verify(delegate.writeLeaf(2, data)).once();
   }
 }
 
 
 @ReflectiveTestCase()
 class _FixedStringCodecTest {
   ByteData buffer;
@@ skipping 87 matching lines @@
   test_write_doesNotExist() {
     expect(() {
       Uint8List page = new Uint8List(PAGE_SIZE);
       manager.write(42, page);
     }, throws);
   }
 }
 
 
 
-class _NodeManagerMock<K, V, N> extends TypedMock implements NodeManager<K, V, N> {
+class _NodeManagerMock<K, V, N> extends TypedMock implements NodeManager<K, V,
+    N> {
   noSuchMethod(Invocation invocation) => super.noSuchMethod(invocation);
 }
 
 
 
 @ReflectiveTestCase()
 class _PageNodeManagerTest {
   static const Codec KEY_CODEC = Uint32Codec.INSTANCE;
   static const int PAGE_SIZE = 128;
   static const Codec VALUE_CODEC = const FixedStringCodec(4);
@@ skipping 80 matching lines @@
   }
 
   test_all() {
     // encode
     codec.encode(buffer, 42);
     expect(bytes, [0, 0, 0, 42]);
     // decode
     expect(codec.decode(buffer), 42);
   }
 }