Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 329613002: Remove impossible early return from CompositedLayerMapping::updateGraphicsLayerGeometry (Closed)

Created:
6 years, 6 months ago by abarth-chromium
Modified:
6 years, 6 months ago
Reviewers:
Ian Vollick
CC:
abarth-chromium, blink-reviews, blink-reviews-rendering, chrishtr, eae+blinkwatch, esprehn, jchaffraix+rendering, leviw+renderwatch, ojan, pdr., rune+blink, zoltan1
Visibility:
Public.

Description

Remove impossible early return from CompositedLayerMapping::updateGraphicsLayerGeometry This case can never occur. This function is now only called from a full compositing update, which cleans out all the dirty bits in the z-list. I ran all the LayoutTests with a CRASH() in this codepath and it never hit. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
6 years, 6 months ago (2014-06-10 18:01:52 UTC) #1
Ian Vollick
On 2014/06/10 18:01:52, abarth wrote: lgtm.
6 years, 6 months ago (2014-06-10 18:03:10 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-10 18:22:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/329613002/1
6 years, 6 months ago (2014-06-10 18:23:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-10 19:14:01 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 20:17:02 UTC) #6
Message was sent while issue was closed.
Change committed as 175915

Powered by Google App Engine
This is Rietveld 408576698