Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 329593002: Pepper: Make ManifestResolveKey resuable. (Closed)

Created:
6 years, 6 months ago by teravest
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Make ManifestResolveKey resuable. I'd like to simplify the OpenResource implementation for the Non-SFI case. I think that this can all stop using the trusted plugin now; this change makes the ManifestResolveKey method easier to use from within ppb_nacl_private_impl.cc. BUG=239656 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276802

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -18 lines) Patch
M components/nacl/renderer/ppb_nacl_private_impl.cc View 2 chunks +27 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
teravest
6 years, 6 months ago (2014-06-10 18:12:16 UTC) #1
teravest
On 2014/06/10 18:12:16, teravest wrote: ping?
6 years, 6 months ago (2014-06-11 20:35:21 UTC) #2
dmichael (off chromium)
lgtm
6 years, 6 months ago (2014-06-11 20:51:56 UTC) #3
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 6 months ago (2014-06-11 20:53:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/329593002/1
6 years, 6 months ago (2014-06-11 20:57:19 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:30:59 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:34:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/21869) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19649)
6 years, 6 months ago (2014-06-11 21:34:04 UTC) #8
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 6 months ago (2014-06-12 15:58:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/329593002/1
6 years, 6 months ago (2014-06-12 16:00:47 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 21:05:12 UTC) #11
Message was sent while issue was closed.
Change committed as 276802

Powered by Google App Engine
This is Rietveld 408576698