[fsp] Group arguments for API methods and events in dictionaries.

chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js

Index: chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js
diff --git a/chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js b/chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js
index f9c196c80645a882be888ef4f0093c6cb2409dcd..caa58eb95bcc000efe17e5ad8d3a7f7395998b62 100644
--- a/chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js
+++ b/chrome/test/data/extensions/api_test/file_system_provider/read_file/test.js
@@ -90,29 +90,28 @@ function getVolumeInfo(fileSystemId, callback) {
  * To successfully acquire a DirectoryEntry, or even a DOMFileSystem, this event
  * must be implemented and return correct values.
  *
- * @param {string} inFileSystemId ID of the file system.
- * @param {string} entryPath Path of the requested entry.
+ * @param {GetMetadataRequestedOptions} options Options.
  * @param {function(Object)} onSuccess Success callback with metadata passed
  *     an argument.
  * @param {function(string)} onError Error callback with an error code.
  */
-function onGetMetadataRequested(inFileSystemId, entryPath, onSuccess, onError) {
-  if (inFileSystemId != FILE_SYSTEM_ID) {
-    onError('SECURITY_ERROR');  // enum ProviderError.
+function onGetMetadataRequested(options, onSuccess, onError) {
+  if (options.fileSystemId != FILE_SYSTEM_ID) {
+    onError('SECURITY');  // enum ProviderError.
     return;
   }
 
-  if (entryPath == '/') {
+  if (options.entryPath == '/') {
     onSuccess(TESTING_ROOT);
     return;
   }
 
-  if (entryPath == '/' + TESTING_TIRAMISU_FILE.name) {
+  if (options.entryPath == '/' + TESTING_TIRAMISU_FILE.name) {
     onSuccess(TESTING_TIRAMISU_FILE);
     return;
   }
 
-  if (entryPath == '/' + TESTING_BROKEN_TIRAMISU_FILE.name) {
+  if (options.entryPath == '/' + TESTING_BROKEN_TIRAMISU_FILE.name) {
     onSuccess(TESTING_BROKEN_TIRAMISU_FILE);
     return;
   }
@@ -124,24 +123,20 @@ function onGetMetadataRequested(inFileSystemId, entryPath, onSuccess, onError) {
  * Requests opening a file at <code>filePath</code>. Further file operations
  * will be associated with the <code>requestId</code>
  *
- * @param {string} inFileSystemId ID of the file system.
- * @param {number} requestId ID of the opening request. Used later for reading.
- * @param {string} filePath Path of the file to be opened.
- * @param {string} mode Mode, either reading or writing.
- * @param {boolean} create True to create if doesn't exist.
+ * @param {OpenFileRequestedOptions} options Options.
  * @param {function()} onSuccess Success callback.
  * @param {function(string)} onError Error callback.
  */
-function onOpenFileRequested(
-    inFileSystemId, requestId, filePath, mode, create, onSuccess, onError) {
-  if (inFileSystemId != FILE_SYSTEM_ID || mode != 'READ' || create) {
-    onError('SECURITY_ERROR');  // enum ProviderError.
+function onOpenFileRequested(options, onSuccess, onError) {
+  if (options.fileSystemId != FILE_SYSTEM_ID || options.mode != 'READ' ||
+      options.create) {
+    onError('SECURITY');  // enum ProviderError.
     return;
   }
 
-  if (filePath == '/' + TESTING_TIRAMISU_FILE.name ||
-      filePath == '/' + TESTING_BROKEN_TIRAMISU_FILE.name) {
-    openedFiles[requestId] = filePath;
+  if (options.filePath == '/' + TESTING_TIRAMISU_FILE.name ||
+      options.filePath == '/' + TESTING_BROKEN_TIRAMISU_FILE.name) {
+    openedFiles[options.requestId] = options.filePath;
     onSuccess();
   } else {
     onError('NOT_FOUND');  // enum ProviderError.
@@ -151,19 +146,18 @@ function onOpenFileRequested(
 /**
  * Requests closing a file previously opened with <code>openRequestId</code>.
  *
- * @param {string} inFileSystemId ID of the file system.
- * @param {number} openRequestId ID of the request used to open the file.
+ * @param {CloseFileRequestedOptions} options Options.
  * @param {function()} onSuccess Success callback.
  * @param {function(string)} onError Error callback.
  */
-function onCloseFileRequested(
-    inFileSystemId, openRequestId, onSuccess, onError) {
-  if (inFileSystemId != FILE_SYSTEM_ID || !openedFiles[openRequestId]) {
-    onError('SECURITY_ERROR');  // enum ProviderError.
+function onCloseFileRequested(options, onSuccess, onError) {
+  if (options.fileSystemId != FILE_SYSTEM_ID ||
+      !openedFiles[options.openRequestId]) {
+    onError('SECURITY');  // enum ProviderError.
     return;
   }
 
-  delete openedFiles[requestId];
+  delete openedFiles[options.openRequestId];
   onSuccess();
 }
 
@@ -171,24 +165,20 @@ function onCloseFileRequested(
  * Requests reading contents of a file, previously opened with <code>
  * openRequestId</code>.
  *
- * @param {string} inFileSystemId ID of the file system.
- * @param {number} openRequestId ID of the request used to open the file.
- * @param {number} offset Offset of the file.
- * @param {number} length Number of bytes to read.
+ * @param {ReadFileRequestedOptions} options Options.
  * @param {function(ArrayBuffer, boolean)} onSuccess Success callback with a
  *     chunk of data, and information if more data will be provided later.
  * @param {function(string)} onError Error callback.
  */
-function onReadFileRequested(
-    inFileSystemId, openRequestId, offset, length, onSuccess, onError) {
-  var filePath = openedFiles[openRequestId];
-  if (inFileSystemId != FILE_SYSTEM_ID || !filePath) {
-    onError('SECURITY_ERROR');  // enum ProviderError.
+function onReadFileRequested(options, onSuccess, onError) {
+  var filePath = openedFiles[options.openRequestId];
+  if (options.fileSystemId != FILE_SYSTEM_ID || !filePath) {
+    onError('SECURITY');  // enum ProviderError.
     return;
   }
 
   if (filePath == '/' + TESTING_TIRAMISU_FILE.name) {
-    var textToSend = TESTING_TEXT.substr(offset, length);
+    var textToSend = TESTING_TEXT.substr(options.offset, options.length);
     var textToSendInChunks = textToSend.split(/(?= )/);
 
     textToSendInChunks.forEach(function(item, index) {
@@ -221,30 +211,33 @@ function onReadFileRequested(
  * @param {function()} callback Success callback.
  */
 function setUp(callback) {
-  chrome.fileSystemProvider.mount(FILE_SYSTEM_ID, 'chocolate.zip', function() {
-    chrome.fileSystemProvider.onGetMetadataRequested.addListener(
-        onGetMetadataRequested);
-    chrome.fileSystemProvider.onOpenFileRequested.addListener(
-        onOpenFileRequested);
-    chrome.fileSystemProvider.onReadFileRequested.addListener(
-        onReadFileRequested);
-    var volumeId =
-        'provided:' + chrome.runtime.id + '-' + FILE_SYSTEM_ID + '-user';
+  chrome.fileSystemProvider.mount(
+      {fileSystemId: FILE_SYSTEM_ID, displayName: 'chocolate.zip'},
+      function() {
+        chrome.fileSystemProvider.onGetMetadataRequested.addListener(
+            onGetMetadataRequested);
+        chrome.fileSystemProvider.onOpenFileRequested.addListener(
+            onOpenFileRequested);
+        chrome.fileSystemProvider.onReadFileRequested.addListener(
+            onReadFileRequested);
+        var volumeId =
+            'provided:' + chrome.runtime.id + '-' + FILE_SYSTEM_ID + '-user';
 
-    getVolumeInfo(FILE_SYSTEM_ID, function(volumeInfo) {
-      chrome.test.assertTrue(!!volumeInfo);
-      chrome.fileBrowserPrivate.requestFileSystem(
-          volumeInfo.volumeId,
-          function(inFileSystem) {
-            chrome.test.assertTrue(!!inFileSystem);
+        getVolumeInfo(FILE_SYSTEM_ID, function(volumeInfo) {
+          chrome.test.assertTrue(!!volumeInfo);
+          chrome.fileBrowserPrivate.requestFileSystem(
+              volumeInfo.volumeId,
+              function(inFileSystem) {
+                chrome.test.assertTrue(!!inFileSystem);
 
-            fileSystem = inFileSystem;
-            callback();
-          });
-    });
-  }, function() {
-    chrome.test.fail();
-  });
+                fileSystem = inFileSystem;
+                callback();
+              });
+        });
+      },
+      function() {
+        chrome.test.fail();
+      });
 }
 
 /**