Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4256)

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/get_metadata.cc

Issue 329483002: [fsp] Group arguments for API methods and events in dictionaries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleaned up. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/operations/get_metadata.cc
diff --git a/chrome/browser/chromeos/file_system_provider/operations/get_metadata.cc b/chrome/browser/chromeos/file_system_provider/operations/get_metadata.cc
index 2b42193d4bc94c89daadb1b8b53ff35abcc89c31..476ac503e6dd4a1d43180f755af6ac2e3cfd526c 100644
--- a/chrome/browser/chromeos/file_system_provider/operations/get_metadata.cc
+++ b/chrome/browser/chromeos/file_system_provider/operations/get_metadata.cc
@@ -48,10 +48,10 @@ bool ConvertRequestValueToFileInfo(scoped_ptr<RequestValue> value,
GetMetadata::GetMetadata(
extensions::EventRouter* event_router,
const ProvidedFileSystemInfo& file_system_info,
- const base::FilePath& directory_path,
+ const base::FilePath& entry_path,
const fileapi::AsyncFileUtil::GetFileInfoCallback& callback)
: Operation(event_router, file_system_info),
- directory_path_(directory_path),
+ entry_path_(entry_path),
callback_(callback) {
}
@@ -59,8 +59,8 @@ GetMetadata::~GetMetadata() {
}
bool GetMetadata::Execute(int request_id) {
- scoped_ptr<base::ListValue> values(new base::ListValue);
- values->AppendString(directory_path_.AsUTF8Unsafe());
+ scoped_ptr<base::DictionaryValue> values(new base::DictionaryValue);
+ values->SetString("entryPath", entry_path_.AsUTF8Unsafe());
return SendEvent(
request_id,
extensions::api::file_system_provider::OnGetMetadataRequested::kEventName,

Powered by Google App Engine
This is Rietveld 408576698