Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc

Issue 329483002: [fsp] Group arguments for API methods and events in dictionaries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleaned up. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/files/file.h" 7 #include "base/files/file.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 base::Unretained(&dispatcher))); 131 base::Unretained(&dispatcher)));
132 132
133 EXPECT_TRUE(read_file.Execute(kRequestId)); 133 EXPECT_TRUE(read_file.Execute(kRequestId));
134 134
135 ASSERT_EQ(1u, dispatcher.events().size()); 135 ASSERT_EQ(1u, dispatcher.events().size());
136 extensions::Event* event = dispatcher.events()[0]; 136 extensions::Event* event = dispatcher.events()[0];
137 EXPECT_EQ( 137 EXPECT_EQ(
138 extensions::api::file_system_provider::OnReadFileRequested::kEventName, 138 extensions::api::file_system_provider::OnReadFileRequested::kEventName,
139 event->event_name); 139 event->event_name);
140 base::ListValue* event_args = event->event_args.get(); 140 base::ListValue* event_args = event->event_args.get();
141 ASSERT_EQ(5u, event_args->GetSize()); 141 ASSERT_EQ(1u, event_args->GetSize());
142
143 base::DictionaryValue* options = NULL;
144 ASSERT_TRUE(event_args->GetDictionary(0, &options));
142 145
143 std::string event_file_system_id; 146 std::string event_file_system_id;
144 EXPECT_TRUE(event_args->GetString(0, &event_file_system_id)); 147 EXPECT_TRUE(options->GetString("fileSystemId", &event_file_system_id));
145 EXPECT_EQ(kFileSystemId, event_file_system_id); 148 EXPECT_EQ(kFileSystemId, event_file_system_id);
146 149
147 int event_request_id = -1; 150 int event_request_id = -1;
148 EXPECT_TRUE(event_args->GetInteger(1, &event_request_id)); 151 EXPECT_TRUE(options->GetInteger("requestId", &event_request_id));
149 EXPECT_EQ(kRequestId, event_request_id); 152 EXPECT_EQ(kRequestId, event_request_id);
150 153
151 int event_file_handle = -1; 154 int event_file_handle = -1;
152 EXPECT_TRUE(event_args->GetInteger(2, &event_file_handle)); 155 EXPECT_TRUE(options->GetInteger("openRequestId", &event_file_handle));
153 EXPECT_EQ(kFileHandle, event_file_handle); 156 EXPECT_EQ(kFileHandle, event_file_handle);
154 157
155 double event_offset = -1; 158 double event_offset = -1;
156 EXPECT_TRUE(event_args->GetDouble(3, &event_offset)); 159 EXPECT_TRUE(options->GetDouble("offset", &event_offset));
157 EXPECT_EQ(kOffset, static_cast<double>(event_offset)); 160 EXPECT_EQ(kOffset, static_cast<double>(event_offset));
158 161
159 int event_length = -1; 162 int event_length = -1;
160 EXPECT_TRUE(event_args->GetInteger(4, &event_length)); 163 EXPECT_TRUE(options->GetInteger("length", &event_length));
161 EXPECT_EQ(kLength, event_length); 164 EXPECT_EQ(kLength, event_length);
162 } 165 }
163 166
164 TEST_F(FileSystemProviderOperationsReadFileTest, Execute_NoListener) { 167 TEST_F(FileSystemProviderOperationsReadFileTest, Execute_NoListener) {
165 LoggingDispatchEventImpl dispatcher(false /* dispatch_reply */); 168 LoggingDispatchEventImpl dispatcher(false /* dispatch_reply */);
166 CallbackLogger callback_logger; 169 CallbackLogger callback_logger;
167 170
168 ReadFile read_file( 171 ReadFile read_file(
169 NULL, 172 NULL,
170 file_system_info_, 173 file_system_info_,
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 read_file.OnError(kRequestId, base::File::FILE_ERROR_TOO_MANY_OPENED); 254 read_file.OnError(kRequestId, base::File::FILE_ERROR_TOO_MANY_OPENED);
252 255
253 ASSERT_EQ(1u, callback_logger.events().size()); 256 ASSERT_EQ(1u, callback_logger.events().size());
254 CallbackLogger::Event* event = callback_logger.events()[0]; 257 CallbackLogger::Event* event = callback_logger.events()[0];
255 EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, event->result()); 258 EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, event->result());
256 } 259 }
257 260
258 } // namespace operations 261 } // namespace operations
259 } // namespace file_system_provider 262 } // namespace file_system_provider
260 } // namespace chromeos 263 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698