Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: chrome/browser/chromeos/file_system_provider/operations/get_metadata_unittest.cc

Issue 329483002: [fsp] Group arguments for API methods and events in dictionaries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleaned up. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/files/file.h" 7 #include "base/files/file.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/json/json_reader.h" 9 #include "base/json/json_reader.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 base::Unretained(&dispatcher))); 122 base::Unretained(&dispatcher)));
123 123
124 EXPECT_TRUE(get_metadata.Execute(kRequestId)); 124 EXPECT_TRUE(get_metadata.Execute(kRequestId));
125 125
126 ASSERT_EQ(1u, dispatcher.events().size()); 126 ASSERT_EQ(1u, dispatcher.events().size());
127 extensions::Event* event = dispatcher.events()[0]; 127 extensions::Event* event = dispatcher.events()[0];
128 EXPECT_EQ( 128 EXPECT_EQ(
129 extensions::api::file_system_provider::OnGetMetadataRequested::kEventName, 129 extensions::api::file_system_provider::OnGetMetadataRequested::kEventName,
130 event->event_name); 130 event->event_name);
131 base::ListValue* event_args = event->event_args.get(); 131 base::ListValue* event_args = event->event_args.get();
132 ASSERT_EQ(3u, event_args->GetSize()); 132 ASSERT_EQ(1u, event_args->GetSize());
133
134 base::DictionaryValue* options = NULL;
135 ASSERT_TRUE(event_args->GetDictionary(0, &options));
133 136
134 std::string event_file_system_id; 137 std::string event_file_system_id;
135 EXPECT_TRUE(event_args->GetString(0, &event_file_system_id)); 138 EXPECT_TRUE(options->GetString("fileSystemId", &event_file_system_id));
136 EXPECT_EQ(kFileSystemId, event_file_system_id); 139 EXPECT_EQ(kFileSystemId, event_file_system_id);
137 140
138 int event_request_id = -1; 141 int event_request_id = -1;
139 EXPECT_TRUE(event_args->GetInteger(1, &event_request_id)); 142 EXPECT_TRUE(options->GetInteger("requestId", &event_request_id));
140 EXPECT_EQ(kRequestId, event_request_id); 143 EXPECT_EQ(kRequestId, event_request_id);
141 144
142 std::string event_directory_path; 145 std::string event_entry_path;
143 EXPECT_TRUE(event_args->GetString(2, &event_directory_path)); 146 EXPECT_TRUE(options->GetString("entryPath", &event_entry_path));
144 EXPECT_EQ(kDirectoryPath, event_directory_path); 147 EXPECT_EQ(kDirectoryPath, event_entry_path);
145 } 148 }
146 149
147 TEST_F(FileSystemProviderOperationsGetMetadataTest, Execute_NoListener) { 150 TEST_F(FileSystemProviderOperationsGetMetadataTest, Execute_NoListener) {
148 LoggingDispatchEventImpl dispatcher(false /* dispatch_reply */); 151 LoggingDispatchEventImpl dispatcher(false /* dispatch_reply */);
149 CallbackLogger callback_logger; 152 CallbackLogger callback_logger;
150 153
151 GetMetadata get_metadata( 154 GetMetadata get_metadata(
152 NULL, 155 NULL,
153 file_system_info_, 156 file_system_info_,
154 base::FilePath::FromUTF8Unsafe(kDirectoryPath), 157 base::FilePath::FromUTF8Unsafe(kDirectoryPath),
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 get_metadata.OnError(kRequestId, base::File::FILE_ERROR_TOO_MANY_OPENED); 251 get_metadata.OnError(kRequestId, base::File::FILE_ERROR_TOO_MANY_OPENED);
249 252
250 ASSERT_EQ(1u, callback_logger.events().size()); 253 ASSERT_EQ(1u, callback_logger.events().size());
251 CallbackLogger::Event* event = callback_logger.events()[0]; 254 CallbackLogger::Event* event = callback_logger.events()[0];
252 EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, event->result()); 255 EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, event->result());
253 } 256 }
254 257
255 } // namespace operations 258 } // namespace operations
256 } // namespace file_system_provider 259 } // namespace file_system_provider
257 } // namespace chromeos 260 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698