Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: chrome/browser/chromeos/file_system_provider/operations/close_file_unittest.cc

Issue 329483002: [fsp] Group arguments for API methods and events in dictionaries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleaned up. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 #include <vector> 6 #include <vector>
7 7
8 #include "base/files/file.h" 8 #include "base/files/file.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 base::Unretained(&dispatcher))); 102 base::Unretained(&dispatcher)));
103 103
104 EXPECT_TRUE(close_file.Execute(kRequestId)); 104 EXPECT_TRUE(close_file.Execute(kRequestId));
105 105
106 ASSERT_EQ(1u, dispatcher.events().size()); 106 ASSERT_EQ(1u, dispatcher.events().size());
107 extensions::Event* event = dispatcher.events()[0]; 107 extensions::Event* event = dispatcher.events()[0];
108 EXPECT_EQ( 108 EXPECT_EQ(
109 extensions::api::file_system_provider::OnCloseFileRequested::kEventName, 109 extensions::api::file_system_provider::OnCloseFileRequested::kEventName,
110 event->event_name); 110 event->event_name);
111 base::ListValue* event_args = event->event_args.get(); 111 base::ListValue* event_args = event->event_args.get();
112 ASSERT_EQ(3u, event_args->GetSize()); 112 ASSERT_EQ(1u, event_args->GetSize());
113
114 base::DictionaryValue* options = NULL;
115 ASSERT_TRUE(event_args->GetDictionary(0, &options));
113 116
114 std::string event_file_system_id; 117 std::string event_file_system_id;
115 EXPECT_TRUE(event_args->GetString(0, &event_file_system_id)); 118 EXPECT_TRUE(options->GetString("fileSystemId", &event_file_system_id));
116 EXPECT_EQ(kFileSystemId, event_file_system_id); 119 EXPECT_EQ(kFileSystemId, event_file_system_id);
117 120
118 int event_request_id = -1; 121 int event_request_id = -1;
119 EXPECT_TRUE(event_args->GetInteger(1, &event_request_id)); 122 EXPECT_TRUE(options->GetInteger("requestId", &event_request_id));
120 EXPECT_EQ(kRequestId, event_request_id); 123 EXPECT_EQ(kRequestId, event_request_id);
121 124
122 int event_open_request_id = -1; 125 int event_open_request_id = -1;
123 EXPECT_TRUE(event_args->GetInteger(2, &event_open_request_id)); 126 EXPECT_TRUE(options->GetInteger("openRequestId", &event_open_request_id));
124 EXPECT_EQ(kOpenRequestId, event_open_request_id); 127 EXPECT_EQ(kOpenRequestId, event_open_request_id);
125 } 128 }
126 129
127 TEST_F(FileSystemProviderOperationsCloseFileTest, Execute_NoListener) { 130 TEST_F(FileSystemProviderOperationsCloseFileTest, Execute_NoListener) {
128 LoggingDispatchEventImpl dispatcher(false /* dispatch_reply */); 131 LoggingDispatchEventImpl dispatcher(false /* dispatch_reply */);
129 CallbackLogger callback_logger; 132 CallbackLogger callback_logger;
130 133
131 CloseFile close_file( 134 CloseFile close_file(
132 NULL, 135 NULL,
133 file_system_info_, 136 file_system_info_,
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 188
186 close_file.OnError(kRequestId, base::File::FILE_ERROR_TOO_MANY_OPENED); 189 close_file.OnError(kRequestId, base::File::FILE_ERROR_TOO_MANY_OPENED);
187 ASSERT_EQ(1u, callback_logger.events().size()); 190 ASSERT_EQ(1u, callback_logger.events().size());
188 EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, 191 EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED,
189 callback_logger.events()[0]); 192 callback_logger.events()[0]);
190 } 193 }
191 194
192 } // namespace operations 195 } // namespace operations
193 } // namespace file_system_provider 196 } // namespace file_system_provider
194 } // namespace chromeos 197 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698