Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 329473003: MacViews: Split out ViewTest.RecreateLayers from view_unittest.cc (Closed)

Created:
6 years, 6 months ago by tapted
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Visibility:
Public.

Description

MacViews: Split out ViewTest.RecreateLayers from view_unittest.cc ViewTest.RecreateLayers creates a layer hierarchy that includes child widgets and pulls an aura dependency into view_unittest.cc. This CL moves the test into a new file - view_unittest_aura.cc to isolate the aura dependency and allow view_unittest.cc to compile on MacViews. After this, an additional 56 views_unittests are compiling (39 pass). BUG=378134 TEST=views_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276534

Patch Set 1 #

Patch Set 2 : compiles #

Patch Set 3 : git-cl-format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -142 lines) Patch
M ui/views/view_unittest.cc View 1 3 chunks +0 lines, -141 lines 0 comments Download
A ui/views/view_unittest_aura.cc View 1 2 1 chunk +160 lines, -0 lines 0 comments Download
M ui/views/views.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tapted
Hi sky PTAL Note the naming: view_unittest_aura (rather than view_aura_unittest). This is to distinguish it ...
6 years, 6 months ago (2014-06-11 07:27:06 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-11 16:01:55 UTC) #2
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 6 months ago (2014-06-12 03:09:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/329473003/40001
6 years, 6 months ago (2014-06-12 03:13:15 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 04:43:51 UTC) #5
Message was sent while issue was closed.
Change committed as 276534

Powered by Google App Engine
This is Rietveld 408576698