Issue 329463004: Oilpan: remove RawPtr<> usage for WebNotification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 329463004: Oilpan: remove RawPtr<> usage for WebNotification. (Closed)

Created:
6 years, 6 months ago by sof

Modified:
6 years, 6 months ago

Reviewers:
tkent, oilpan-reviews, haraken

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Oilpan: remove RawPtr<> usage for WebNotification. Go the whole hog and use (non-const) bare pointers for the conversion constructor and assignment operator. R= BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175875

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	Source/web/NotificationPresenterImpl.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/web/WebNotification.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	public/web/WebNotification.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/329463004/1

6 years, 6 months ago (2014-06-10 07:29:14 UTC) #3

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...

6 years, 6 months ago (2014-06-10 08:31:54 UTC) #5

Message was sent while issue was closed.

Change committed as 175875