Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 32943007: Remove incorrect deriving of CppVariant from WebNonCopyable. (Closed)

Created:
7 years, 1 month ago by r.kasibhatla
Modified:
7 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove incorrect deriving of CppVariant from WebNonCopyable. CppVariant is supposed to be a copyable class and we override the default copy ctor and assignment operator for the same. It is wrongly derived from WebNonCopyable. Remove the incorrect inheritance. R=jochen BUG=None TEST=None; no behavior change; Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160319

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/testing/runner/CppVariant.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
r.kasibhatla
PTAL. As per our discussion yesterday, just correcting the CppVariant class only.
7 years, 1 month ago (2013-10-23 06:02:43 UTC) #1
jochen (gone - plz use gerrit)
s/unneccessary/incorrect/ :) lgtm
7 years, 1 month ago (2013-10-23 07:05:27 UTC) #2
r.kasibhatla
On 2013/10/23 07:05:27, jochen wrote: > s/unneccessary/incorrect/ :) > > lgtm Done. Corrected the message. ...
7 years, 1 month ago (2013-10-23 07:31:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/32943007/1
7 years, 1 month ago (2013-10-23 07:32:01 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-10-23 08:43:06 UTC) #5
Message was sent while issue was closed.
Change committed as 160319

Powered by Google App Engine
This is Rietveld 408576698